[SQL VM] az sql vm show: Add configuration options to --expand flag#15156
Conversation
ghost
added
the
customer-reported
|
Thank you for your contribution rchlkm! We will review the pull request and get back to you soon. |
Contributor
Author
Collaborator
|
add to S176 |
yareyes
reviewed
Sep 14, 2020
Juliehzl
changed the title
az sql vm show: Add configuration options to --expand flag
Juliehzl
reviewed
Sep 15, 2020
Contributor
Author
|
@Juliehzl thanks for reviewing this PR. This PR is actually specific to the SQL VM command module, not SQL. I believe the title should be [SQL VM]. |
Juliehzl
changed the title
az sql vm show: Add configuration options to --expand flagaz sql vm show: Add configuration options to --expand flag
Contributor
updated |
yareyes
approved these changes
Sep 23, 2020
Juliehzl
approved these changes
Sep 25, 2020
Juliehzl
pushed a commit
to Juliehzl/azure-cli
that referenced
this pull request
Sep 30, 2020
…Azure#15156) * {Docs} Remove stale reference in README to closed issue about extensions (Azure#12771) * Added more sqlvm configuration options to --expand flag * style changes to comply with pylint and pep8 format * removed commments in HISTORY.rst * refactored expand params to use nargs=+ design pattern Co-authored-by: Daniel Miller <daniel.keegan.miller@gmail.com> Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a small addition to the --expand flag.
The --expand flag previously only accepted
*as an argument. With these changes, the --expand flag accepts the following: AutoBackupSettings, AutoPatchingSettings, KeyCredentialSettings, ServerConfiguratationsManagementSettings. The flag can also accept any space-separated combination of these arguments.Tests added accordingly.
Testing Guide
az sql vm show -g <Resource Group Name> -n <SQL VM Name> --expand <Setting1> <Setting2>History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.