[SQL] Adding AAD-only Support for SQL Managed Instances and Servers#15292
Conversation
Contributor
|
Looks good. |
Collaborator
|
SQL |
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
reviewed
Oct 14, 2020
Juliehzl
requested changes
Oct 14, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
please add test scenarios for all new commands and parameters.
Juliehzl
requested changes
Oct 20, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
Could you also add test scenarios for your new commands?
Contributor
Author
|
Sure. I'll write them up. |
Contributor
Author
|
Tests were added |
Contributor
Author
|
Style updates |
Contributor
Author
|
@Juliehzl I don't think that error is caused by me. according to the logs the error comes from loading ai-examples extension which I haven't touched. Please give guidance on how to proceed. |
Juliehzl
reviewed
Oct 21, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
Contributor
Yes. We could fix the CI error. |
Contributor
Author
|
Changes were made! @Juliehzl |
Juliehzl
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for a new feature to az cli. Azure Active Directory only allows for only AD users to be admins not traditional username/password combinations. This feature has been added to Azure Python SDK and is now being supported in az cli
Using either a managed instance or server with a ad admin run:
az sql server ad-only-auth enable
az sql server ad-only-auth disable
az sql server ad-only-auth get
az sql mi ad-only-auth enable
az sql mi ad-only-auth disable
az sql mi ad-only-auth get
to enable, disable and show AAD only authentication.