Conversation
AssertionError: You need to call 'result' or 'wait' on all LROPoller you have created
Server tests still failed.
server tests pass now
OlegSternbergIBM
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution Oleza1972! We will review the pull request and get back to you soon. |
Collaborator
|
sql |
jaredmoo
reviewed
Oct 8, 2020
Contributor
|
/azp run |
1 similar comment
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15444 in repo Azure/azure-cli |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
requested changes
Oct 16, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
please resolve all my comments and change the title format.
And edit the history notes part in description, e.g.
History Notes
[Compute] sig image-definition create: add --features
[Compute] New API version of gallery_images 2020-09-30
Juliehzl
reviewed
Oct 20, 2020
Juliehzl
reviewed
Oct 20, 2020
Juliehzl
reviewed
Oct 20, 2020
Juliehzl
reviewed
Oct 20, 2020
Juliehzl
reviewed
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR the following commands have been extended to support Event Hub and Log Analytics:
az sql server audit-policy show:
az sql db audit-policy show:
An extended JSON body is returned now.
See:
https://docs.microsoft.com/en-us/rest/api/sql/server%20auditing%20settings/get
https://docs.microsoft.com/en-us/rest/api/sql/database%20auditing%20settings/get
az sql server audit-policy update,
az sql db audit-policy update:
A new command line arguments have been added:
--blob-storage-target-state - enables\disables blob storage as auditing logs target
--log-analytics-target-state - enables\disables log analytics as auditing logs target
--log-analytics-workspace-resource-id - log analytics workspace resource id
--event-hub-target-state - enables\disables event hub as auditing logs target
--event-hub-authorization-rule-id - event hub authorization rule id
--event-hub - event hub name
Examples of commands:
sql db audit-policy update -g my_resource_group -s my_server -n my_database --state Enabled --blob-storage-target-state Enabled --storage-endpoint https://mystorageaccount.blob.core.windows.net/
sql db audit-policy update -g my_resource_group -s my_server -n my_database --state Enabled --blob-storage-target-state Disabled
sql server audit-policy update -g my_resource_group -n my_server --state Enabled --log-analytics-target-state Enabled --log-analytics-workspace-resource-id /subscriptions/1111-2222-3333-444-5555555/resourcegroups/my_resource_group/providers/microsoft.operationalinsights/workspaces/my_workspace
sql server audit-policy update -g my_resource_group -n my_server --state Enabled --log-analytics-target-state Disabled --event-hub-target-state Enabled --event-hub-authorization-rule-id /subscriptions/1111-2222-3333-4444/resourceGroups/my_resource_group/providers/Microsoft.EventHub/namespaces/my_eventhub_namespace/authorizationrules/my_eventhub_auth_rule_name --event-hub my_event_hub_name
Testing Guide
Unit tests test_sql_server_security_mgmt and test_sql_db_security_mgmt cover the test for the change.
History Notes
[SQL] az sql db audit-policy show: extend to show database's audit policy including LA and EH data
[SQL] az sql db audit-policy update: extend to allow LA and EH update along with database's audit policy
[SQL] az sql db audit-policy wait: place the CLI in a waiting state until a condition of the database's audit policy is met.
[SQL] az sql server audit-policy show: extend to show servers's audit policy including LA and EH data
[SQL] az sql server audit-policy update: extend to allow LA and EH update along with server's audit policy
[SQL] az sql server audit-policy wait: place the CLI in a waiting state until a condition of the server's audit policy is met.