Conversation
Collaborator
|
RDBMS |
yonzhan
requested review from
Juliehzl,
arrownj,
evelyn-ys,
jsntcy and
zhoxing-ms
arde0708
reviewed
Oct 9, 2020
arde0708
reviewed
Oct 9, 2020
arde0708
reviewed
Oct 9, 2020
arde0708
reviewed
Oct 9, 2020
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 15450 in repo Azure/azure-cli |
DaeunYim
force-pushed
the
daeunyim/sterling-s177
branch
from
6de230a to
bc8f8d9
Compare
DaeunYim
force-pushed
the
daeunyim/sterling-s177
branch
from
bc8f8d9 to
a7981ff
Compare
DaeunYim
changed the title
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
Comment on lines
+35
to
+43
| server_name_help = "Name of the server. The name can contain only lowercase letters, numbers, and the hyphen (-) character. " + \ | ||
| "Minimum 3 characters and maximum 63 characters." | ||
| server_name_scope = ['{}'.format(command_group)] | ||
| server_name_setter_arg_type = CLIArgumentType(metavar='NAME', help=server_name_help, id_part='name', | ||
| local_context_attribute=LocalContextAttribute(name='server_name', actions=[LocalContextAction.SET], scopes=server_name_scope)) | ||
| server_name_getter_arg_type = CLIArgumentType(metavar='NAME', help=server_name_help, id_part='name', | ||
| local_context_attribute=LocalContextAttribute(name='server_name', actions=[LocalContextAction.GET], scopes=server_name_scope)) | ||
| server_name_arg_type = CLIArgumentType(metavar='NAME', help=server_name_help, id_part='name', | ||
| local_context_attribute=LocalContextAttribute(name='server_name', actions=[LocalContextAction.SET, LocalContextAction.GET], scopes=server_name_scope)) |
Contributor
There was a problem hiding this comment.
@arrownj could you help with local context part?
Juliehzl
reviewed
Oct 16, 2020
Juliehzl
reviewed
Oct 16, 2020
arrownj
approved these changes
Oct 20, 2020
Contributor
arrownj
left a comment
arrownj
left a comment
There was a problem hiding this comment.
Looks good for local context part.
Juliehzl
approved these changes
Oct 20, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
LGTM for command design
haroldrandom
approved these changes
Oct 20, 2020
haroldrandom
approved these changes
Oct 20, 2020
Contributor
haroldrandom
left a comment
haroldrandom
left a comment
There was a problem hiding this comment.
will merge once @arde0708 approve
arde0708
approved these changes
Oct 20, 2020
Contributor
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
az config param-persist on
e.g.) az postgres server create -g <group_name> -n <server_name> -l => az postgres server show
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.