Skip to content

[Storage] az storage queue list: Track2 supported#15494

Merged
evelyn-ys merged 8 commits intoAzure:devfrom
evelyn-ys:queue-track2
Oct 22, 2020
Merged

[Storage] az storage queue list: Track2 supported#15494
evelyn-ys merged 8 commits intoAzure:devfrom
evelyn-ys:queue-track2

Conversation

@evelyn-ys
Copy link
Member

Description

Migrate az storage queue to track2 sdk. Only list command is implemented in main repo, others will be developed in azure-cli-extension.

Testing Guide

az storage queue list --account-name $STORAGE_ACCOUNT

@evelyn-ys evelyn-ys requested a review from Juliehzl October 12, 2020 14:18
@evelyn-ys evelyn-ys self-assigned this Oct 12, 2020
@yonzhan yonzhan added this to the S177 milestone Oct 12, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 12, 2020

Storage

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add test for account key and connection string scenarios?

@evelyn-ys evelyn-ys requested a review from Juliehzl October 14, 2020 05:22
Comment on lines +1345 to +1353
c.argument('include_metadata', help='Specifies that queue metadata be returned in the response.')
c.argument('marker', arg_type=marker_type)
c.argument('num_results', arg_type=num_results_type)
c.argument('prefix', help='Filters the results to return only queues whose names '
'begin with the specified prefix.')
c.argument('show_next_marker', action='store_true',
help='Show nextMarker in result when specified.')
c.extra('timeout', help='Request timeout in seconds. Applies to each call to the service.', type=int)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use active voice

@evelyn-ys evelyn-ys requested a review from Juliehzl October 21, 2020 06:38
@evelyn-ys evelyn-ys merged commit 80a1696 into Azure:dev Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants