[Batch] Fix #15464: Update check for pfx file without password in batch create_certificate

[Zay2k]

Description

Add a check for file ending when determining certificate format of certificate uploaded to batch account. When a .pfx-certificate is uploaded without a password, the extra check is needed to not parse it as .cer-file.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

[ghost]

Thank you for your contribution Zay2k! We will review the pull request and get back to you soon.

[Zay2k]

An improvement of this would be to do the check with OpenSSL.crypto or similar, like in keyvault module.

azure-cli/src/azure-cli/azure/cli/command_modules/keyvault/custom.py

Line 1469 in 26fea08

x509 = crypto.load_pkcs12(certificate_data).get_certificate()

[yonzhan]

Batch

[yungezz]

hi @qwordy , could you pls review the PR? thanks

[yungezz]

hi @Zay2k @qwordy what's the status of this PR, is it ok to merge?

[Zay2k]

hi @Zay2k @qwordy what's the status of this PR, is it ok to merge?

It is ok for me. What's the next step, should I merge dev into this, or do you just merge it?

[qwordy]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).