[SQL] az sql db replica create: Add --partner-database argument#15577
Merged
[SQL] az sql db replica create: Add --partner-database argument#15577
Conversation
bradrich-msft
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
Collaborator
|
SQL |
Juliehzl
requested changes
Oct 20, 2020
Contributor
Juliehzl
left a comment
Juliehzl
left a comment
There was a problem hiding this comment.
No need to change history.rst now. We will auto-generate history.rst according to your PR title.
Member
|
Since we will auto-generate history.rst according to your PR title. It will be nicer to make the title: |
bradrich-msft
changed the title
evelyn-ys
approved these changes
Oct 21, 2020
Contributor
Author
|
Hello @evelyn-ys it appears this pull request has been approved. Can it now be merged? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding optional parameter to sql db replica create command, --partner-database. This allows creation of secondary
replicas that have a different name than the source database.
Testing Guide
sql db replica create --partner-database foo
History Notes
Not a breaking change
This checklist is used to make sure that common guidelines for a pull request are followed.
[x ] The PR title and description has followed the guideline in Submitting Pull Requests.
[x ] I adhere to the Command Guidelines.