{Auto Complete} Fix default completer#15599
Merged
fengzhou-msft merged 2 commits intoAzure:devfrom Oct 22, 2020
Merged
Conversation
fengzhou-msft
requested review from
Juliehzl,
arrownj,
haroldrandom,
jiasli,
jsntcy and
mmyyrroonn
as code owners
Collaborator
|
Which platform does it support? |
houk-ms
approved these changes
Oct 22, 2020
Member
Author
Linux and macOS. |
jiasli
approved these changes
Oct 22, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #3807
The current default completer only takes one positional argument and will throw an error when invoked in
argcompletewith keyword argument:https://github.com/kislyuk/argcomplete/blob/a93a4f4dc785373f320d168d2d5a1a11bdc50315/argcomplete/__init__.py#L452-L454
completer(prefix=cword_prefix, action=active_action, parser=parser, parsed_args=parsed_args)This PR makes the default completer take any number of positional or keyword arguments.
Testing Guide
On Ubuntu, turn on argcomplete debug with:
export _ARC_DEBUG=1Type the following command and press tab key.
az vm show --ids /subYou can see the error:
TypeError: <lambda>() got an unexpected keyword argument 'prefix'Apply the change in this PR to argcomplete by running:
eval "$(register-python-argcomplete az)"Repeat the step for tab completion and the error is gone.
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.