Skip to content

[Compute] Fix update permission check issue#15606

Merged
qwordy merged 4 commits intoAzure:devfrom
qwordy:15594
Oct 29, 2020
Merged

[Compute] Fix update permission check issue#15606
qwordy merged 4 commits intoAzure:devfrom
qwordy:15594

Conversation

@qwordy
Copy link
Member

@qwordy qwordy commented Oct 22, 2020

Description

Resolve #15594

The following operations are braking

az vmss update --name aks-agentpool-13930963-vmss --resource-group MC_adadilli_adadilliSIGNewest_australiaeast --instance-id 0 --protect-from-scale-set-actions False --protect-from-scale-in
az vmss encryption enable --disk-encryption-keyvault adadilliKV3 --name aks-agentpool-13930963-vmss --resource-group MC_adadilli_adadilliSIGNewest_australiaeast

due to the following permission issue:

ForbiddenError: The client has permission to perform action 'Microsoft.Compute/galleries/images/versions/read' on scope '/subscriptions/c1089427-83d3-4286-9f35-5af546a6eb67/resourceGroups/MC_adadilli_adadilliSIGNewest_australiaeast/providers/Microsoft.Compute/virtualMachineScaleSets/aks-agentpool-13930963-vmss/virtualmachines/0', however the current tenant '72f988bf-86f1-41af-91ab-2d7cd011db47' is not authorized to access linked subscription '109a5e88-712a-48ae-9078-9ca8b3c81345'.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@qwordy qwordy requested a review from arrownj as a code owner October 22, 2020 05:25
@yungezz yungezz added the Compute az vm/vmss/image/disk/snapshot label Oct 22, 2020
Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. any test to cover it?

@qwordy
Copy link
Member Author

qwordy commented Oct 22, 2020

LGTM. any test to cover it?

A unit test that checks the request doesn't contain the imageId field is feasible.

@qwordy
Copy link
Member Author

qwordy commented Oct 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@qwordy qwordy merged commit 47ac4ea into Azure:dev Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compute az vm/vmss/image/disk/snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error of CLI commands for vmss with SIG

4 participants