{Error Improvement} Catch and categorize HttpError in core exception handler#15613
Conversation
Contributor
Author
|
Previously, these errors make CLI crashed and were categorized into ClientError. Now they are categorized into UserFault or ServiceError according to the status code. |
fengzhou-msft
approved these changes
Oct 22, 2020
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HTTPErrors are widely raised in different command groups, while they are not caught in core exception handler. Previously, CLI would crash and users would get the raw traces when these error happen.
This PR supports
Here is a table showing the uncaught HTTPError count in AzureCLI@2.12.0 in last month.
Testing Guide
You can test the case by raising an HTTPError manually in your codes, for example
Previously, when the HTTPError was not caught, CLI just crashed.
Now,