{Profile} Add CREDENTIAL_WARNING_MESSAGE for more commands#16222
Merged
{Profile} Add CREDENTIAL_WARNING_MESSAGE for more commands#16222
Conversation
jiasli
requested review from
evelyn-ys,
fengzhou-msft and
jsntcy
as code owners
jiasli
commented
Dec 10, 2020
Comment on lines
73
to
76
Member
Author
There was a problem hiding this comment.
Refine the help message of az account show.
jiasli
commented
Dec 10, 2020
Member
Author
There was a problem hiding this comment.
⚠ --sdk-auth should be deprecated for az account show because it is regurgitating the credential which is not a secure practice.
jiasli
commented
Dec 10, 2020
Member
Author
There was a problem hiding this comment.
Reverting the not logic as --sdk-auth is the uncommon code path.
jiasli
commented
Dec 10, 2020
Member
Author
There was a problem hiding this comment.
Print the warning earlier so that it is printed when show_auth_for_sdk is True.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
|
Profile |
evelyn-ys
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refine #15825: Add long-summary/warning for commands generating credentials
This PR shows the
CREDENTIAL_WARNING_MESSAGEfor more commands:az account show --helpaz account show --sdk-authaz ad sp create-for-rbac --sdk-auth