Draft
Conversation
chenlomis
reviewed
Dec 14, 2020
chenlomis
left a comment
There was a problem hiding this comment.
Very cool!
To confirm, some of the text and output under def login_hinters are still in discussion right?
This is just to review that post output hint is now supported under login and also the demo command ..(?)
Member
Author
|
/azp run |
|
Pull request contains merge conflicts. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR requires
Add experimental post-output hint which is shown after a command succeeds (except for
az --versionwhich follows a different code path).Testing Guide
Currently, only
az loginandaz demo hintis registered with hinters:History Notes
[Hint] az login: Add experimental post-output hint