{RDBMS} Add rdbms code owner#16383
Merged
Merged
Conversation
jiasli
reviewed
Dec 29, 2020
| /src/azure-cli/azure/cli/command_modules/policyinsights/ @cheggert | ||
| /src/azure-cli/azure/cli/command_modules/profile/ @jiasli @evelyn-ys @fengzhou-msft | ||
| /src/azure-cli/azure/cli/command_modules/rdbms/ @Juliehzl @evelyn-ys | ||
| /src/azure-cli/azure/cli/command_modules/rdbms/ @arde0708 @Juliehzl @evelyn-ys |
Member
There was a problem hiding this comment.
👍 Good to have a member from service team to ensure the code quality.
Member
There was a problem hiding this comment.
To add more context:
#16350 introduced an incorrect parameter name serv_name which would have been detected by a service team reviewer:
delegation = Delegation(name=delegation_service_name, serv_name=delegation_service_name)
jiasli
approved these changes
Dec 29, 2020
Collaborator
|
RDBMS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We may need service team member as rdbms code owner to ensure the code quality as we CLI team members may not know exactly and explictly how everything works.
For example, network migration need service team's review: #16350
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.