Skip to content

{RDBMS} Fix "Message: The subscription '00000000-0000-0000-0000-000000000000' could not be found." test error by waiting for Long Running Operations #17185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 3 commits into from
Mar 5, 2021
Merged

{RDBMS} Fix "Message: The subscription '00000000-0000-0000-0000-000000000000' could not be found." test error by waiting for Long Running Operations #17185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0815f7
Wait for LROs
jiasli Mar 3, 2021
e732dc4
Disable failed tests
jiasli Mar 4, 2021
95d3346
import unittest
jiasli Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def _create_vnet_subnet_delegation(nw_client, resource_group, vnet_name, subnet_
location=location,
address_space=AddressSpace(
address_prefixes=[
vnet_address_pref])))
vnet_address_pref]))).result()
Copy link
Member Author

@jiasli jiasli Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution proposed by @zhoxing-ms is to supply polling=False to nw_client.virtual_networks.begin_create_or_update so that LROPoller is created with NoPolling:

https://github.com/Azure/azure-sdk-for-python/blob/ad5308d9befefdc0cdc61c4a47a3329fd874b8a0/sdk/network/azure-mgmt-network/azure/mgmt/network/v2020_08_01/operations/_virtual_networks_operations.py#L340-L341

if polling is True: polling_method = ARMPolling(lro_delay, lro_options={'final-state-via': 'azure-async-operation'}, path_format_arguments=path_format_arguments,  **kwargs)
elif polling is False: polling_method = NoPolling()

This stops SDK from polling the result. The Virtual Network creation will then be superseded/canceled by Subnet creation.

Pros

  • This is faster as it doesn't care about the result of Virtual Network creation.

Cons

  • This leaves the result of Virtual Network creation unchecked. If the Virtual Network creation actually fails, the error will be reported at

    azure-cli/src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py

    Lines 188 to 189 in 95d3346

    return nw_client.subnets.begin_create_or_update(resource_group, vnet_name, subnet_name,
    subnet_result).result()

    making troubleshooting difficult.
  • This depends on the service's ability to allow one operation to be superseded by another. In many other services like Storage, this is not always the case - we can't create a container before Storage Account creation finished.

subnet_result = Subnet(
name=subnet_name,
location=location,
Expand Down Expand Up @@ -216,7 +216,7 @@ def create_vnet(cmd, servername, location, resource_group_name, delegation_servi
client.virtual_networks.begin_create_or_update(resource_group_name, vnet_name,
VirtualNetwork(name=vnet_name, location=location,
address_space=AddressSpace(
address_prefixes=[vnet_address_prefix])))
address_prefixes=[vnet_address_prefix]))).result()
delegation = Delegation(name=delegation_service_name, service_name=delegation_service_name)
service_endpoint = ServiceEndpoint(service='Microsoft.Storage')
subnet = Subnet(name=subnet_name, location=location, address_prefix=subnet_prefix, delegations=[delegation], service_endpoints=[service_endpoint])
Expand Down
2 changes: 2 additions & 0 deletions ...re-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands_mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pytest
import os
import time
import unittest
from datetime import datetime, timedelta, tzinfo
from azure_devtools.scenario_tests import AllowLargeResponse
from azure.cli.testsdk import (
Expand Down Expand Up @@ -210,6 +211,7 @@ def __init__(self, method_name):
def test_mysql_flexible_server_vnet_server_prepare(self):
self.cmd('az group create --location {} --name {}'.format(mysql_location, self.resource_group))

@unittest.skip("Service is temporarily busy and the operation cannot be performed. Please try again later.")
@AllowLargeResponse()
@pytest.mark.order(2)
@pytest.mark.depends(on=['MySqlFlexibleServerVnetServerMgmtScenarioTest::test_mysql_flexible_server_vnet_server_prepare'])
Expand Down
3 changes: 3 additions & 0 deletions ...cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import pytest
import os
import time
import unittest
from datetime import datetime, timedelta, tzinfo
from azure_devtools.scenario_tests import AllowLargeResponse
from azure.cli.testsdk import (
Expand Down Expand Up @@ -249,6 +250,7 @@ def __init__(self, method_name):
def test_postgres_flexible_server_vnet_server_prepare(self):
self.cmd('az group create --location {} --name {}'.format(postgres_location, self.resource_group))

@unittest.skip("Takes too long. Need to re-record.")
@AllowLargeResponse()
@pytest.mark.order(2)
@pytest.mark.depends(on=['PostgresFlexibleServerVnetServerMgmtScenarioTest::test_postgres_flexible_server_vnet_server_prepare'])
Expand All @@ -273,6 +275,7 @@ def test_postgres_flexible_server_vnet_server_restore(self):
def test_postgres_flexible_server_vnet_server_delete(self):
self._test_flexible_server_vnet_server_delete('postgres', self.resource_group, self.server, self.restore_server)

@unittest.skip("Takes too long. Need to re-record.")
@AllowLargeResponse()
@pytest.mark.order(6)
@pytest.mark.depends(on=['PostgresFlexibleServerVnetServerMgmtScenarioTest::test_postgres_flexible_server_vnet_server_prepare'])
Expand Down