[Network] Bump version from '2020-08-01' to '2020-11-01'#17290
[Network] Bump version from '2020-08-01' to '2020-11-01'#17290
Conversation
msyyc
requested review from
Juliehzl,
digimaun,
evelyn-ys,
fengzhou-msft,
houk-ms,
jaredmoo,
jiasli,
jqhuangonearth,
jsntcy,
kairu-ms,
qwordy,
temandr,
v-Ajnava,
yungezz and
zhoxing-ms
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
.../azure/cli/command_modules/vm/tests/latest/recordings/test_vm_create_auto_create_subnet.yaml
Outdated
Show resolved
Hide resolved
qwordy
left a comment
qwordy
left a comment
There was a problem hiding this comment.
You upgrated network to 18.0.0. However, in yaml file
- AZURECLI/2.19.1 azsdk-python-azure-mgmt-network/17.1.0
Fake file. Request change.
|
Network |
done |
|
@msyyc Replacing keywords in yaml file is dangerous. I am not aware of whether network upgrade breaks vm's tests. |
I have run the live test for compute. The result is same with weekly live report. |
|
@msyyc, only tests that cannot pass live run should use |
got it |
|
|
||
| self.cmd('az eventgrid topic delete --name {topic_name} --resource-group {rg}') | ||
|
|
||
| @unittest.skip('live test always fails, need fix by owners') |
There was a problem hiding this comment.
Does this test fail in weekly live run?
If yes, we'd better replace "api version" in recording file and create an issue to owner to fix this test.
There was a problem hiding this comment.
Yes, it failed in weekly live run. It will fail even with recording mode. So we have to skip it.
| @@ -851,7 +851,7 @@ def setUp(self): | |||
| self.cmd('extension add -n eventgrid') | |||
|
|
|||
| def tearDown(self): | |||
| self.cmd('extension remove -n eventgrid') | |||
| # self.cmd('extension remove -n eventgrid') | |||
There was a problem hiding this comment.
Any specific reason for this change which caused #17434?
There was a problem hiding this comment.
We should not suppose to remove extension after test done to avoid other test when parallel run. For example both NetworkVirtualApplianceScenarioTest and NetworkSecurityPartnerProviderScenarioTest rely on virtual-wan extension. If the first one remove extension when tearDown, it will cause error for unfinished one. We encounter this issue before.
8 participants
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.