Merged
Conversation
Collaborator
|
Core |
kairu-ms
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
msyyc and
qwordy
kairu-ms
force-pushed
the
az-command-group-refactoring
branch
from
02b67ef to
e5eb2dc
Compare
kairu-ms
commented
Mar 23, 2021
Contributor
Author
There was a problem hiding this comment.
It's replaced by GenericUpdateCommandOperation
kairu-ms
commented
Mar 23, 2021
Contributor
Author
There was a problem hiding this comment.
It's replaced by WaitCommandOperation
kairu-ms
commented
Mar 23, 2021
Contributor
Author
There was a problem hiding this comment.
It's replaced by ShowCommandOperation
kairu-ms
commented
Mar 23, 2021
Contributor
Author
There was a problem hiding this comment.
Internal functions are replaced by CommandOperation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Mar 23, 2021
Contributor
There was a problem hiding this comment.
the same concern as above
Contributor
Author
There was a problem hiding this comment.
Same reason as above
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
Juliehzl
reviewed
Mar 23, 2021
src/azure-cli-core/azure/cli/core/commands/command_operation.py
Outdated
Show resolved
Hide resolved
kairu-ms
force-pushed
the
az-command-group-refactoring
branch
from
faab3a1 to
5866b8e
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
This is a rather big PR, please add description to illustrate
|
jiasli
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context for the change
AzCommandGroup are using
_cli_command,_cli_show_command,_cli_wait_commandand_cli_generic_update_commandfunction to register a command into command table. The logic of above functions are not clear, and they are not compatible with Configurational CLI.What is changed
_cli_generic_update_commandby classGenericUpdateCommandOperation_cli_wait_commandby classWaitCommandOperation_cli_show_commandby classShowCommandOperation_cli_commandbyadd_cli_commandand its internal functions move to classCommandOperationgeneric_update_command,_wait_command,_show_commandand_commandmethods ofAzCommandGroupHow to test
This change should be 100% compatible with existing code. So it should pass all of the existing tests.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.