-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{HDInsight}Use getting default sku api to set workernode and headnode size if customer does not provide #17552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
00b9235
ab16df0
03436bc
7d98b1f
06f6ec5
adab2d2
c7b9f98
18e8b8d
1eb5074
cc3a159
af8f98e
0f904b9
d17a993
331b406
c98c195
ee648a0
d2faa9f
64d0de4
7b250f5
03c8785
2f814b1
82ce0cc
3731883
1e48381
b50a530
15a1cef
a7fb6f7
ebaf9ce
45825e1
5385a09
bdea8f7
193217e
af85c40
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this way, you will change default value for your CLI parameter, which is breaking. Is it by design?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we want to do this, but I forget it is a breaking change. This change will not have any impact on existing scripts, yes but it will change the parameter help info. Can we check in in this release cycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a good experience for customer to have such breaking change in stable azure cli. Is there strong business justification for such breaking change?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because at before the default value is large, and it will be converted into some concrete value. As time goes, we will deprecate some vm size this will cause issue. If it is not acceptable for this release, it also makes sense for us. And when is the next release which accepts breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S187 - 05/25/2021 release cycle could accept breaking change. CLI only accepts breaking change twice a year.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yonzhan Thanks. Then this PR will target at S187, and I will announce there will be breaking change in S186. You can skip this PR in this S185. Thank you~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.