{SQL} Fixing failing test for log replay #17672
Merged
Conversation
milanbrkic-ms
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
milanbrkic-ms
changed the title
Collaborator
|
SQL |
…kic/fixing_test_records
…/fixing_test_records
Contributor
Author
|
Fix for the issue - #17603 |
Juliehzl
reviewed
Apr 14, 2021
Comment on lines
+5711
to
+5712
| 'storage_sas': 'sp=rl&st=2021-04-12T13:07:20Z&se=2021-04-30T21:07:20Z&spr=https&sv=2020-02-10&sr=c&sig=igoGWjvYceuSkuHRzkm6oPPxitRlSYgGvmdwTbr7WTM%3D', | ||
| 'storage_uri': 'https://mibrkicstorage.blob.core.windows.net/mibrkicportal', |
Contributor
There was a problem hiding this comment.
Exposing sas token for your storage account has security issue.
Could you create a storage account (using StorageAccountPreparer) and generate sas token on demand?
Contributor
Author
There was a problem hiding this comment.
I can try, but the thing is that I will need to publish file to storage account as well. With powershell I had a lot of problems doing that. Hope it will not be the case 🤞
working This reverts commit 8a5c5ce.
Juliehzl
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.