{AppService} Fix linter error in _github_oauth.py#17998
Merged
Conversation
qwordy
reviewed
May 7, 2021
src/azure-cli/azure/cli/command_modules/appservice/_github_oauth.py
Outdated
Show resolved
Hide resolved
Collaborator
|
AppService |
qwordy
approved these changes
May 7, 2021
evelyn-ys
reviewed
May 7, 2021
|
|
||
|
|
||
| def get_github_access_token(cmd, scope_list=None): | ||
| def get_github_access_token(cmd, scope_list=None): # pylint: disable=unused-argument |
Member
There was a problem hiding this comment.
How about remove cmd parameter directly? As far as I know, custom function is allowed to not contain cmd according to
azure-cli/src/azure-cli-core/azure/cli/core/__init__.py
Lines 807 to 824 in 32d2691
L813 will process smartly
Member
Author
There was a problem hiding this comment.
This get_github_access_token is not used anywhere. Leave it to the author @calvinsID to further decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For unknown reason, Pylint 2.3.0 fails to find linter errors in
_github_oauth.pyadded by #17826.After bumping Pylint 2.8.0 (#17861), those errors are revealed.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=880573&view=logs&j=36dd4138-4d53-5e46-00d9-e5cd9744be05&t=1cf3879c-0a42-5ccd-7693-7a4781d739d8&l=107