{Keyvault} Fix keyvault packaging tests#18919
Closed
Conversation
kairu-ms
approved these changes
Jul 19, 2021
jiasli
reviewed
Jul 19, 2021
src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_commands.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Keyvault |
evelyn-ys
commented
Jul 19, 2021
src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_commands.py
Outdated
Show resolved
Hide resolved
jiasli
reviewed
Jul 19, 2021
Member
|
You may directly push the branch to |
Member
|
To better help the reader find failed CI tasks, please consider including a direct link to failed CI tasks in the PR description, instead of using screenshots. |
Member
|
If the issue is caused by a missing certificate file, why isn't the error triggered before? |
Member
Author
Got it! Redirect to #18922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our CI fails in (CI link)

with such error
when runs into L1895
azure-cli/src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_commands.py
Lines 1892 to 1895 in 562eeaa
It's because the
cert_secret_pathisTEST_DIR/cert_secretwithout any file extension and our packaging script doesn't cover file without file extension:azure-cli/scripts/ci/build.sh
Lines 135 to 168 in 562eeaa
So the code runs into this
if not os.path.exists(cert_secret_path)but no related request found in yaml file.This PR changed
TEST_DIR/cert_secrettoTEST_DIR/cert_secret.derand added.derto packaging file, also re-record yaml file with related request.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.