decode binary string as utf-8 in win branch#18974
Closed
Conversation
ghost
added
the
customer-reported
|
Thank you for your contribution bitcloud! We will review the pull request and get back to you soon. |
Contributor
Author
|
I couldn't test this patch as I don't have a Windows system at hand. But it should work as it seems to be the same issue we had on the linux/macos code path. |
Contributor
Author
|
There seems to be a better PR already on the way: #18909 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The websocket response can be a string for text or bytes for an utf-8 string. utf-8 was not handled properly. This pr adds detection of bytes and decoding as utf-8 string before writing to the console.
This is the same fix as #18384 applied to the windows code as well.
Fixes: #18251 (comment)
Testing Guide
az container createwith a long living container on a Windows systemaz container exec --exec-command "/bin/bash" ...History Notes
[container] az container exec: decode received bytes as utf-8 string (Windows as well now)
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.