{Packaging} Loosen cryptography dependency#19639
Merged
Conversation
jiasli
commented
Sep 22, 2021
cryptography dependencycryptography dependency
Collaborator
|
Packaging |
Member
Author
|
@glaubitz, I have totally removed the lower bound. Will this suit your need? |
evelyn-ys
approved these changes
Sep 24, 2021
calvinhzy
approved these changes
Sep 24, 2021
|
Is version 3.0 actually the absolute minimum that you need now? That is, is there functionality that you need that is not part of version 2.8? |
Member
Author
|
We don't require >3.0 now. Any version works. |
|
Then either remove the version requirement or use at least 2.8 which is what SLE-12 and SLE-15 are shipping at the moment. |
Member
Author
It is already removed. |
This was referenced Oct 8, 2021
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Reasons why we can loose the
cryptographydependency now:For upper bound
#15687 (comment) set an upper bound for
cryptographydue to pyca/cryptography#5771.By following https://cryptography.io/en/latest/installation/#alpine, I am now able to install
cryptography3.4.8 on Alpine Linux (#19591). There is no need to set upper bound now.For lower bound
Community packagers ask us not to bump the minimum dependency in
setup.pyas this causes trouble for platforms that doesn't support newer versions ofcryptography(#15687 (comment)). By loosing the dependency oncryptography, users or packagers themselves are now responsible for security vulnerabilities in older versions ofcryptography.As we still pin the version in
requirements.*.txt, packages distributed by us still containcryptographywhich is security-complaint.