{Container} Fix intermittent test failures; Issues #19835 and #19804#19848
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom Oct 12, 2021
Merged
{Container} Fix intermittent test failures; Issues #19835 and #19804#19848zhoxing-ms merged 2 commits intoAzure:devfrom
zhoxing-ms merged 2 commits intoAzure:devfrom
Conversation
Collaborator
|
Container |
jiasli
reviewed
Oct 12, 2021
| vnet_name, | ||
| VirtualNetwork(name=vnet_name, | ||
| location=location, | ||
| polling=False, |
Member
There was a problem hiding this comment.
Be careful about the side-effect of polling=False (#17185 (comment)).
Member
There was a problem hiding this comment.
polling is added to the wrong place. It should be added to begin_create_or_update, not VirtualNetwork. Also, polling should be added to ALL begin_create_or_updates.
Actually, the preferred fix is to use .result().
jiasli
approved these changes
Oct 12, 2021
jiasli
reviewed
Oct 12, 2021
Comment on lines
+466
to
+467
| # Changing to live only because of intermittent test failures: https://github.com/Azure/azure-cli/issues/19804 | ||
| @live_only() |
Member
There was a problem hiding this comment.
Better to identify why exactly the test fails in CI.
Contributor
There was a problem hiding this comment.
I think so.
@joseph-porter We can merge this PR first to avoid the impact of this test in CI. Please find out the root cause of CI issue in the future and make this test support recording again
zhoxing-ms
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLI team reported intermittent test failures in container tests, these changes should address the issues.
#19804 - Changed Attach test to be live only
#19835 - Changed vnet create to not use polling
Testing Guide
Changes only made to test, no commands affected
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.