Skip to content

[Synapse] az synapse kql-script: New command group to support Kusto script#20459

Merged
evelyn-ys merged 12 commits intoAzure:devfrom
zesluo:zeshi/kustoscriptsupport
Nov 29, 2021
Merged

[Synapse] az synapse kql-script: New command group to support Kusto script#20459
evelyn-ys merged 12 commits intoAzure:devfrom
zesluo:zeshi/kustoscriptsupport

Conversation

@zesluo
Copy link

@zesluo zesluo commented Nov 22, 2021

Description
Added kutso script command for Azure cli

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@zesluo zesluo changed the title Zeshi/kustoscriptsupport [Synapse]Kusto Script Support Nov 22, 2021
@zesluo zesluo changed the title [Synapse]Kusto Script Support [Synapse]Added Kusto Script Support Nov 22, 2021
@zesluo zesluo closed this Nov 22, 2021
@zesluo zesluo reopened this Nov 22, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 22, 2021

Synapse

azure-cli==2.30.0
azure-common==1.1.22
azure-core==1.19.0
azure-core==1.20.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why do you need to upgrade azure-core?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure-synapse-artifacts==0.10.0 needs azure-core upgrade^_^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to confirm with @jiasli whether upgrading azure-core will impact other modules or not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine if CI passes.

Copy link
Author

@zesluo zesluo Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli What does CI mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADO pipeline triggered by each PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems upgrading azure-core does impact other modules. After this PR get merged, our CI crashes...

65 tests fail because of azure.core.pipeline.transport._requests_basic.StreamDownloadGenerator throwing azure.core.exceptions.IncompleteReadError: ('Connection broken:......). And 62 of them are webapp tests.
See pipeline:
image

@jiasli @zhoxing-ms Can you help take a look?
@zesluo Do you mind if I revert this PR if other modules' failure can't be fixed before the code complete date(12/01)?

@evelyn-ys evelyn-ys changed the title [Synapse]Added Kusto Script Support [Synapse] az synapse kql-script: Support Kusto script Nov 25, 2021
@evelyn-ys evelyn-ys changed the title [Synapse] az synapse kql-script: Support Kusto script [Synapse] az synapse kql-script: New command group to support Kusto script Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants