Skip to content

{CI} Make recording responses' Content-Length match the body #20533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiasli wants to merge 2 commits into from
Closed

{CI} Make recording responses' Content-Length match the body #20533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ed85b0
create_random_name
jiasli Nov 29, 2021
764b2b9
tests
jiasli Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/azure-cli-testsdk/azure/cli/testsdk/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,14 @@ def tearDown(self):

def create_random_name(self, prefix, length):
self.test_resources_count += 1
moniker = '{}{:06}'.format(prefix, self.test_resources_count)
# The moniker's length must match the specified `length` argument, otherwise in recordings' response,
# Content-Length header's value won't match the length of the body, causing failure due to the
# azure-core check: https://github.com/Azure/azure-sdk-for-python/pull/20888

# For example, for prefix='vnetwebapp', length=24
replacement_length = length - len(prefix) # 14
moniker_template = '{}{:0' + str(replacement_length) + '}' # '{}{:014}'
moniker = moniker_template.format(prefix, self.test_resources_count) # 'vnetwebapp00000000000002'

if self.in_recording:
name = create_random_name(prefix, length)
Expand Down
Loading