{Core} Fix _normalize_expires_on on Python 3.6#20874
Merged
Conversation
evelyn-ys
approved these changes
Dec 30, 2021
5ec68f3 to
eb2bcb7
Compare
calvinhzy
approved these changes
Dec 30, 2021
Collaborator
|
Core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #20215 (comment)
Python 3.6 doesn't recognize timezone
%zas+00:00. It only recognizes+0000:which means
az login --identitywith managed identity in App Service container still doesn't work with DEB, RPM packages, etc.https://docs.python.org/3/library/datetime.html#technical-detail
There is indeed a test
azure.cli.core.auth.tests.test_adal_authentication.TestUtil.test_normalize_expires_onto verify this:azure-cli/src/azure-cli-core/azure/cli/core/auth/tests/test_adal_authentication.py
Lines 13 to 14 in af483f5
However, the test is not executed by CI for Python 3.6 due to
azdevissue