[Packaging] BREAKING CHANGE: Drop jmespath-terminal from docker image#21206
Merged
[Packaging] BREAKING CHANGE: Drop jmespath-terminal from docker image#21206
jmespath-terminal from docker image#21206Conversation
zhoxing-ms
approved these changes
Feb 7, 2022
Collaborator
|
Packaging |
jmespath-terminal from docker imagejmespath-terminal from docker image
evelyn-ys
approved these changes
Feb 7, 2022
wangzelin007
approved these changes
Feb 7, 2022
zhoxing-ms
pushed a commit
to zhoxing-ms/azure-cli
that referenced
this pull request
Feb 14, 2022
3 tasks
zhoxing-ms
added a commit
that referenced
this pull request
Feb 14, 2022
* [Packaging] BREAKING CHANGE: Drop `jmespath-terminal` from docker image (#21206) * {Packaging} Fix CI job "Test Yum Package" by using `centos7` (#21207) * Update azure-pipelines.yml for Azure Pipelines (#21230) Pin version for cred scan Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
jmespath-terminalno longer installes with latestsetuptoolsbecause it uses very oldurwid==1.2.2(jmespath/jmespath.terminal#19). This issue was reported in 2018 but per https://pypi.org/project/jmespath-terminal/, the latest version ofjmespath-terminalwas released on Oct 6, 2015.This causes CI failure and blocks PR (#21057 (comment)):
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1341309&view=logs&j=a3141784-dfa9-5792-78cc-844daee2d774&t=b2b6de04-64e4-5812-4fff-06c02d19f4c2&l=214
Since
jmespath-terminalseems to be no longer maintained, we should drop it.