[EventGrid] Support user identity and mixed mode by rohkuma-microsoft · Pull Request #21648 · Azure/azure-cli

rohkuma-microsoft · 2022-03-15T17:33:51Z

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2022-03-15T23:52:52Z

EventGrid

evelyn-ys · 2022-03-24T09:43:31Z

/azp run

azure-pipelines · 2022-03-24T09:43:44Z

Azure Pipelines successfully started running 2 pipeline(s).

evelyn-ys · 2022-03-24T09:46:21Z

The design doesn't seem to follow https://github.com/Azure/azure-cli/blob/dev/doc/managed_identity_command_guideline.md

Add @zhoxing-ms for review

zhoxing-ms · 2022-03-28T10:08:42Z

For az <resource> create/update, please use --mi-user-assigned <AzureResourceId1> <AzureResourceId2> instead of --identity userassigned --user-assigned <AzureResourceId1> <AzureResourceId2> enable-managed-identity-during-resource-creation

Please note that the --user-assigned is used in the scenario of operate-managed-identity-on-existing-resource for az <resource> identity assign/remove commands

zhoxing-ms · 2022-03-29T09:18:31Z

Please note that the parameter --identity is no longer required in the design specifications.

--identity userassigned --mi-user-assigned <AzureResourceId1> <AzureResourceId2> should be --mi-user-assigned <AzureResourceId1> <AzureResourceId2>
--identity systemassigned should be --mi-system-assigned
--identity mixed --mi-user-assigned <AzureResourceId1> <AzureResourceId2> should be --mi-system-assigned --mi-user-assigned <AzureResourceId1> <AzureResourceId2>
Therefore, you may need to deprecate the --identity parameter with the deprecate_info flag deprecating-commands-and-arguments

evelyn-ys · 2022-03-31T04:12:53Z

Please note that the parameter --identity is no longer required in the design specifications.

--identity userassigned --mi-user-assigned <AzureResourceId1> <AzureResourceId2> should be --mi-user-assigned <AzureResourceId1> <AzureResourceId2>

--identity systemassigned should be --mi-system-assigned

--identity mixed --mi-user-assigned <AzureResourceId1> <AzureResourceId2> should be --mi-system-assigned --mi-user-assigned <AzureResourceId1> <AzureResourceId2>
Therefore, you may need to deprecate the --identity parameter with the deprecate_info flag deprecating-commands-and-arguments

Additionally, --identity now only accept noidentity and systemassigned and the definition is not changed in this PR

zhoxing-ms · 2022-03-31T09:31:55Z

src/azure-cli/azure/cli/command_modules/eventgrid/custom.py

+    elif identity_type_name is None and user_identity_properties is not None and mi_system_assigned is not None:
+        result = IDENTITY_MIXED_MODE
+    elif identity_type_name is not None and (user_identity_properties is not None or mi_system_assigned is not None):
+        raise CLIError('usage error: cannot use --identity together with --mi-system-assigned or --mi-user-assigned')


Please use the specific error type MutuallyExclusiveArgumentError instead of CLIError

zhoxing-ms · 2022-03-31T09:38:22Z

Please deprecate the --identity parameter with the deprecate_info flag. doc link: deprecating-commands-and-arguments

Please note that adding deprecated_info flag will not directly cause breaking change to users, and users can temporarily keep their existing behavior. We add deprecated_info flag just to notify users migrate the current non-standard behavior to a compliant and unified way.

zhoxing-ms · 2022-03-31T09:41:43Z

Please refer to doc submitting-pull-requests to write the current changes in detail in the PR title and PR description, these contents will be written into the history notes

jiasli · 2022-04-01T01:37:59Z

src/azure-cli/azure/cli/command_modules/eventgrid/_params.py

        c.argument('inbound_ip_rules', action=AddInboundIpRule, nargs='+')
        c.argument('sku', arg_type=sku_type)
-        c.argument('identity', arg_type=identity_type)
+        c.argument('identity', arg_type=identity_type, deprecate_info=c.deprecate(expiration='2.46.0'))


This may cause unexpected CI failure in the future. We recommend removing a deprecated argument manually.

Well. Another deprecation indeed caused problem today after upgrading Azure CLI version to 2.35.0: #20682 (comment)

Adding User identity and mixed mode

1fcb6b2

rohkuma-microsoft requested a review from evelyn-ys as a code owner March 15, 2022 17:33

rohkuma-microsoft changed the title ~~Adding User identity and mixed mode~~ [Az EventGrid] Adding User identity and mixed mode Mar 15, 2022

yonzhan requested a review from calvinhzy March 15, 2022 23:53

yonzhan assigned evelyn-ys Mar 15, 2022

yonzhan added this to the Mar 2022 (2022-04-05) milestone Mar 15, 2022

Verified by running live test

251b2fd

rohkuma-microsoft changed the title ~~[Az EventGrid] Adding User identity and mixed mode~~ [Az EventGrid] Add User identity and mixed mode Mar 24, 2022

rohkuma-microsoft added 3 commits March 24, 2022 00:50

fixing formatting issues

6c3d11b

fix linter issues

7e30a05

fix cred scan

af9efb5

evelyn-ys requested a review from zhoxing-ms March 24, 2022 09:44

rohkuma-microsoft added 3 commits March 24, 2022 22:51

addressing pr comments

76fba58

pr fix

809aa8d

remove code

b44d526

fix pr comments

9f65f83

rohkuma-microsoft added 3 commits March 30, 2022 16:35

addressing pr comments

17d33eb

fix style issues

e27011f

remove unneeded param

faccc97

zhoxing-ms reviewed Mar 31, 2022

View reviewed changes

Address pr comments

c8f6cf0

evelyn-ys approved these changes Apr 1, 2022

View reviewed changes

evelyn-ys changed the title ~~[Az EventGrid] Add User identity and mixed mode~~ [EventGrid] Support user identity and mixed mode Apr 1, 2022

evelyn-ys merged commit 05c9098 into Azure:dev Apr 1, 2022

jiasli reviewed Apr 1, 2022

View reviewed changes

evelyn-ys mentioned this pull request Apr 6, 2022

[Eventgrid] Remove deprecated parameter --identity in time #21951

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EventGrid] Support user identity and mixed mode#21648

[EventGrid] Support user identity and mixed mode#21648
evelyn-ys merged 13 commits intoAzure:devfrom
rohkuma-microsoft:dev

rohkuma-microsoft commented Mar 15, 2022

Uh oh!

yonzhan commented Mar 15, 2022

Uh oh!

evelyn-ys commented Mar 24, 2022

Uh oh!

azure-pipelines bot commented Mar 24, 2022

Uh oh!

evelyn-ys commented Mar 24, 2022

Uh oh!

zhoxing-ms commented Mar 28, 2022 •

edited

Loading

Uh oh!

zhoxing-ms commented Mar 29, 2022

Uh oh!

evelyn-ys commented Mar 31, 2022

Uh oh!

zhoxing-ms Mar 31, 2022

Uh oh!

zhoxing-ms commented Mar 31, 2022

Uh oh!

zhoxing-ms commented Mar 31, 2022

Uh oh!

jiasli Apr 1, 2022

Uh oh!

jiasli Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rohkuma-microsoft commented Mar 15, 2022

Uh oh!

yonzhan commented Mar 15, 2022

Uh oh!

evelyn-ys commented Mar 24, 2022

Uh oh!

azure-pipelines bot commented Mar 24, 2022

Uh oh!

evelyn-ys commented Mar 24, 2022

Uh oh!

zhoxing-ms commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhoxing-ms commented Mar 29, 2022

Uh oh!

evelyn-ys commented Mar 31, 2022

Uh oh!

zhoxing-ms Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms commented Mar 31, 2022

Uh oh!

zhoxing-ms commented Mar 31, 2022

Uh oh!

jiasli Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

jiasli Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhoxing-ms commented Mar 28, 2022 •

edited

Loading