Skip to content

[Sql] BREAKING CHANGE: Sdk major version bump#21681

Merged
evelyn-ys merged 14 commits intoAzure:devfrom
milanbrkic-ms:geozoneParamMI
Mar 29, 2022
Merged

[Sql] BREAKING CHANGE: Sdk major version bump#21681
evelyn-ys merged 14 commits intoAzure:devfrom
milanbrkic-ms:geozoneParamMI

Conversation

@milanbrkic-ms
Copy link
Contributor

@milanbrkic-ms milanbrkic-ms commented Mar 17, 2022

Description

In this PR azure-mgmt-sql is bumped to latest version which is a new major version. A lot of changes were introduced:

  1. Response for commands in az sql mi has breaking change where new parameters are returned (currentBackupsStorageRedundancy, requestedBackupStorageRedundancy)
  2. Remove tde list-activity command as it is no longer supported.
  3. Adding support for update backup storage redundancy for sql mi set

Testing Guide

for (3) added new test that is specifically testing this feature.

History Notes

[Sql] BREAKING CHANGE: az sql db tde list-activity: Command no longer exists
[Sql] BREAKING CHANGE: az sql mi show/create/update/list: Instead of backupStorageRedundancy, currentBackupsStorageRedundancy and requestedBackupStorageRedundancy properties are returned


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added Auto-Assign Auto assign by bot SQL az sql labels Mar 17, 2022
@ghost ghost requested a review from yonzhan March 17, 2022 11:58
@ghost ghost assigned evelyn-ys Mar 17, 2022
@ghost ghost requested a review from wangzelin007 March 17, 2022 11:59
@ghost ghost assigned zhoxing-ms Mar 17, 2022
@ghost ghost added the Backup label Mar 17, 2022
@ghost ghost requested review from jsntcy and zhoxing-ms March 17, 2022 11:59
@milanbrkic-ms milanbrkic-ms changed the title [Sql] BREAKING CHANGE: sdk major version bump [Sql] BREAKING CHANGE: Sdk major version bump Mar 17, 2022
@yonzhan yonzhan added this to the Mar 2022 (2022-04-06) milestone Mar 17, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 17, 2022

Sql

@milanbrkic-ms
Copy link
Contributor Author

@evelyn-ys Can you please help me understand this sphinx issue? And maybe a hint on how to resolve it :) Thanks

@evelyn-ys
Copy link
Member

Seems like it fails in check sql mi create help args:

Test failed. Help args are different.

CLI help args:--collation, --public-data-endpoint-enabled, --key-id -k, --name -n, --backup-storage-redundancy --bsr, --assign-identity -i, --enable-ad-only-auth, --external-admin-principal-type, --location -l, --proxy-override, --user-assigned-identity-id -a, --external-admin-name, --resource-group -g, --identity-type -t, --minimal-tls-version, --vnet-name, --pid --primary-user-assigned-identity-id, --yes -y, --license-type, --edition --tier -e, --external-admin-sid, --tags, --capacity -c, --family -f, --subnet, --only-show-errors, --no-wait, --timezone-id, --storage, --maint-config-id -m

Doc help args: --collation, --public-data-endpoint-enabled, --admin-password -p, --key-id -k, --backup-storage-redundancy --bsr, --name -n, --assign-identity -i, --enable-ad-only-auth, --external-admin-principal-type, --location -l, --proxy-override, --user-assigned-identity-id -a, --external-admin-name, --resource-group -g, --identity-type -t, --minimal-tls-version, --vnet-name, --pid --primary-user-assigned-identity-id, --yes -y, --license-type, --edition --tier -e, --external-admin-sid, --tags, --capacity -c, --admin-user -u, --family -f, --subnet, --only-show-errors, --no-wait, --timezone-id, --storage, --maint-config-id -m.

@evelyn-ys
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

JMESPathCheck('dtu', 250),
JMESPathCheck('zoneRedundant', True)])

# Skipping test because provisioning of servers are not available on euap region, but feature is only on euap region
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can feature be available in euap region without server available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed api version in yaml files per you suggestion

@evelyn-ys evelyn-ys merged commit ef03b0e into Azure:dev Mar 29, 2022
@jiasli
Copy link
Member

jiasli commented Mar 29, 2022

This PR breaks CI:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1466412&view=logs&j=ad51cf76-b294-5bde-777e-be77cc5f3050&t=0e02ab23-4098-514d-f7b9-ab422251bbb2

2022-03-29T02:16:29.3378803Z         except CannotOverwriteExistingCassetteException as ex:
2022-03-29T02:16:29.3379238Z >           raise AssertionError(ex)
2022-03-29T02:16:29.3380350Z E           AssertionError: Can't overwrite existing cassette ('/opt/az/lib/python3.8/site-packages/azure/cli/command_modules/monitor/tests/latest/recordings/test_metric_alert_for_sql_database_scope.yaml') in your current record mode ('once').
2022-03-29T02:16:29.3382083Z E           No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_metric_alert_v1_2000001/providers/Microsoft.Sql/servers/clitestservermatricalertA000002/databases/cliautomationdb01?api-version=2021-05-01-preview>) was found.
2022-03-29T02:16:29.3383114Z E           Found 1 similar requests with 1 different matcher(s) :
2022-03-29T02:16:29.3383519Z E           
2022-03-29T02:16:29.3384713Z E           1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_metric_alert_v1_2000001/providers/Microsoft.Sql/servers/clitestservermatricalertA000002/databases/cliautomationdb01?api-version=2021-02-01-preview>).
2022-03-29T02:16:29.3385863Z E           Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
2022-03-29T02:16:29.3386340Z E           Matchers failed :
2022-03-29T02:16:29.3386940Z E           _custom_request_query_matcher - assertion failure :
2022-03-29T02:16:29.3387367Z E           None
2022-03-29T02:16:29.3387562Z 
2022-03-29T02:16:29.3388186Z /opt/az/lib/python3.8/site-packages/azure/cli/testsdk/base.py:299: AssertionError
2022-03-29T02:16:29.3389118Z ----------------------------- Captured stdout call -----------------------------
2022-03-29T02:16:29.3389583Z None
2022-03-29T02:16:29.3390202Z ------------ generated xml file: /azure_cli_test_result/monitor.xml ------------
2022-03-29T02:16:29.3390794Z =========================== short test summary info ============================
2022-03-29T02:16:29.3391462Z FAILED tests/latest/test_monitor_metric_alert_scenarios.py::MonitorTests::test_metric_alert_for_sql_database_scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot SQL az sql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants