[NetAppFiles] Update azure-mgmt-netapp version to 7.0.0#21712
[NetAppFiles] Update azure-mgmt-netapp version to 7.0.0#21712
Conversation
|
NetAppFiles |
|
@hildurhodd, Please fix CI issues |
hildurhodd
force-pushed
the
NFSAAS-29397-update-to-2021-10-01
branch
from
ccdc56e to
1314544
Compare
- Added subvolumes command group with following commands: -- show -- list -- create -- update -- delete - Added restore-files command to snapshot command group - Added force parameter to delete volume command - Added parameter ldap-search-scope to account ad create - Added parameter enable-subvolumes to volume create - Added parameter unix-permission to volume update - Fixed list parameters that were declared as tag type - Help updated - Tests updated and tests added for new features - New recordings gathered
Fixing invalid parameter name Removing short parameter options for subvolumes
hildurhodd
force-pushed
the
NFSAAS-29397-update-to-2021-10-01
branch
from
1314544 to
53d072b
Compare
…thout breaking the commands
| file_paths=file_paths, | ||
| destination_path=destination_path | ||
| ) | ||
| client.begin_restore_files(resource_group_name, account_name, pool_name, volume_name, snapshot_name, body) |
There was a problem hiding this comment.
The client method start with begin_ prefix is long running operation. Why not add --no-wait for those kind of command?
kairu-ms
left a comment
kairu-ms
left a comment
There was a problem hiding this comment.
Looks good to me on code. I find all the long running commands in netappfiles don't support --no-wait. Any reason for that?
Thanks for the review. We honestly don't know the reason for not supporting --no-wait, so my assumption is just lack of knowledge. |
|
Hi @hildurhodd, I've merged this PR to support the change of your PR first. |
Hi @kairu-ms, thanks for this. I will create a ticket for no-wait support, and it will be included in the coming pull requests |
4 participants
Description
Update azure-mgmt-netapp dependency to version 7.0.0 and changes made according to that version.
Fixed list parameters that were declared as tag type.
Fixed boolean parameters for active directory commands.
Fixed NFSv3 volume creation with no export policy.
Testing Guide
History Notes
[NetAppFiles]
az netappfiles snapshot restore-files: New command to restore specified files from the specified snapshot to the active filesystem[NetAppFiles]
az netappfiles volume create: Add optional parameters--enable-subvolumes[NetAppFiles]
az netappfiles volume delete: Add optional parameter--force-deleteor--force[NetAppFiles]
az netappfiles volume update: Add optional parameter--unix-permissions[NetAppFiles]
az netappfiles subvolume: New command group to manage subvolume resources[NetAppFiles]
az netappfiles subvolume create: New command to create subvolume[NetAppFiles]
az netappfiles subvolume show: New command to get specified subvolume[NetAppFiles]
az netappfiles subvolume update: New command to update specified subvolume[NetAppFiles]
az netappfiles subvolume list: New command to get all subvolume in a specified volume[NetAppFiles]
az netappfiles subvolume delete: New command to delete specified subvolume[NetAppFiles]
az netappfiles subvolume metadata: New command group to manage subvolume metadata resources[NetAppFiles]
az netappfiles subvolume metadata show: New command to get details about a specified subvolume[NetAppFiles]
az netappfiles account ad add: New optional parameters to support ldap search scope--user-dn,--group-dnand--group-filter[NetAppFiles]
az netappfiles account ad update: New optional parameters to support ldap search scope--user-dn,--group-dnand--group-filterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.