[SQL] az command sql db str-policy set: Make --diffbackup-hours parameter optional#21852
[SQL] az command sql db str-policy set: Make --diffbackup-hours parameter optional#21852
az command sql db str-policy set: Make --diffbackup-hours parameter optional#21852Conversation
ghost
added
ghost
requested a review
from 
danikaZ
requested review from
ericshape,
jiasli,
lululilliancoding and
zhoxing-ms
and removed request for
jsntcy,
wangzelin007 and
zhoxing-ms
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
| 'retention_days_v2': 6, | ||
| 'diffbackup_hours_v2': 12 | ||
| 'diffbackup_hours_v2': 12, | ||
| 'retention_days_v3': 5, |
There was a problem hiding this comment.
only two groups of retention_Days and diffbackup_hours should be enough for the testing
There was a problem hiding this comment.
Three sets are better, because set str-policy using set 2 could verify that both retention days and diff backup hours work as expected.
|
the pipelines are failed. you might need to record the corresponding test again. |
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
|
You will need to rerun the test so does it can create full API record json file. Check-in that json record file to pass the pipeline Checks. The record file end up with .yaml and under path "src/azure-cli/azure/cli/command_modules/sql/tests/latest/recordings". |
The pipeline has succeeded with the latest changes. Thanks! |
|
SQL |
evelyn-ys
changed the title
az command sql db str-policy set: Make diffbackup_hours parameter optionalaz command sql db str-policy set: Make --diffbackup-hours parameter optional
7 participants
Description
Make diffbackup_hours optional in sql db str-policy set.
We are releasing public preview feature short term retention parity for Very Large Database (VLDB) on May 1st .
We recently noticed a bug in Cli which requires differential backup interval as a required parameter. ([SQL] 'az sql db str-policy set/show': Add Set and Show ShortTermRetentionPolicy by lululilliancoding · Pull Request #14919 · Azure/azure-cli (github.com).
We are changing the parameter diffbackup_hours to be an optional parameter
Testing Guide
sql db str-policy set -g WestUS2ResourceGroup -s lillian-westus2-server -n ps5691 --retention-days 7
History Notes
[SQL]
az command sql db str-policy set: Makediffbackup_hoursparameter optionalThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.