[Role] `az ad/role`: Azure AD Graph API to Microsoft Graph API migration by jiasli · Pull Request #22432 · Azure/azure-cli

jiasli · 2022-05-13T09:32:43Z

Description

According to https://docs.microsoft.com/en-us/graph/migrate-azure-ad-graph-overview

Azure Active Directory (Azure AD) Graph is deprecated but won't be retired on June 30, 2022 as previously announced. Listening closely to your feedback about the challenges of migrating such a critical dependency, we're delaying the retirement date through at least the end of this year, 2022. We’ll provide a retirement update mid-calendar year including releasing more tools to help you to migrate your apps.

This PR migrates the underlying API of az ad and az role from AD Graph API to Microsoft Graph API.

Testing Guide

az ad sp create-for-rbac
az ad app create --display-name mytestapp

# Other commands under
az ad ...
az role ...

History Notes

[Role] BREAKING CHANGE: az az/role: Migrate the underlying API of az ad and az role from AD Graph API to Microsoft Graph API. For more details, see Microsoft Graph migration

azure-pipelines · 2022-05-13T09:42:50Z

Azure Pipelines successfully started running 2 pipeline(s).

yonzhan · 2022-05-13T09:59:26Z

This is huge achievement. Nice work ! !

jiasli · 2022-05-13T11:46:19Z

src/azure-cli/azure/cli/command_modules/role/__init__.py

The warning message has been updated.

jiasli · 2022-05-16T06:42:11Z

History notes should be added after merging this PR to bypass "Check the Format of Pull Request Title and Content".

History Notes

[Role] BREAKING CHANGE: az az/role: Migrate the underlying API of az ad and az role from AD Graph API to Microsoft Graph API. For more details, see Microsoft Graph migration

src/azure-cli-core/azure/cli/core/util.py

src/azure-cli-testsdk/azure/cli/testsdk/utilities.py

jsntcy · 2022-05-16T06:58:13Z

src/azure-cli-testsdk/azure/cli/testsdk/utilities.py

+    PWD_REPLACEMENT = 'replaced-microsoft-graph-password'
+
+    def __init__(self):
+        self._activated = False


What's the purpose for _activated?

This way, we can make this replacer's process_response only be called for /addPassword API, saving some time. I kept the original design of GraphClientPasswordReplacer and StorageAccountKeyReplacer.

(cherry picked from commit e8bfbd4)

lkurzyniec · 2022-05-16T15:40:49Z

Awesome job, great news!
Can you estimate when it will be released?

jiasli · 2022-05-16T15:48:23Z

Awesome job, great news! Can you estimate when it will be released?

Thanks @lkurzyniec. 😊 You may refer to the release schedule here: https://github.com/Azure/azure-cli/milestone/118

jiasli requested review from DaeunYim, andyliuliming, calvinhzy, digimaun, evelyn-ys, jsntcy, kairu-ms, wangzelin007 and zhoxing-ms as code owners May 13, 2022 09:32

ghost requested a review from yonzhan May 13, 2022 09:32

ghost added the Auto-Assign Auto assign by bot label May 13, 2022

ghost assigned jiasli May 13, 2022

ghost added this to the May 2022 (2022-05-24) - For Build milestone May 13, 2022

ghost added the RBAC az role label May 13, 2022

jiasli mentioned this pull request May 13, 2022

[Role] az ad/role: Azure AD Graph API to Microsoft Graph API migration #22431

Closed

ghost added Graph az ad AAD labels May 13, 2022

jiasli commented May 13, 2022

View reviewed changes

src/azure-cli/azure/cli/command_modules/role/__init__.py Outdated

Copy link

Member Author

jiasli May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message has been updated.

jiasli requested a review from chasewilson May 13, 2022 11:47

yonzhan approved these changes May 16, 2022

View reviewed changes

evelyn-ys approved these changes May 16, 2022

View reviewed changes

msgraph

95f762f

jiasli force-pushed the msgraph branch from ac0cf25 to 95f762f Compare May 16, 2022 06:40

kairu-ms approved these changes May 16, 2022

View reviewed changes

jsntcy reviewed May 16, 2022

View reviewed changes

src/azure-cli-core/azure/cli/core/util.py Show resolved Hide resolved

jsntcy reviewed May 16, 2022

View reviewed changes

src/azure-cli-testsdk/azure/cli/testsdk/utilities.py Show resolved Hide resolved

jsntcy reviewed May 16, 2022

View reviewed changes

zhoxing-ms approved these changes May 16, 2022

View reviewed changes

calvinhzy approved these changes May 16, 2022

View reviewed changes

{AKS} Remove deprecated pre-process functions for sp (Azure#22458)

5307041

(cherry picked from commit e8bfbd4)

FumingZhang approved these changes May 16, 2022

View reviewed changes

jiasli mentioned this pull request May 16, 2022

{AKS} Remove deprecated pre-process functions for sp #22458

Merged

3 tasks

jiasli merged commit cac3f06 into Azure:dev May 16, 2022

jiasli deleted the msgraph branch May 16, 2022 15:47

jiasli mentioned this pull request May 24, 2022

Azure CLI is migrated to Microsoft Graph in 2.37.0 #22580

Closed

magodo mentioned this pull request May 30, 2022

Auth: populateConfig for CLI is missing object_id since CLI v2.37.0 hashicorp/go-azure-helpers#118

Closed

jiasli mentioned this pull request Aug 10, 2022

[AD] az ad app/sp update: Add --parameters to replace generic update arguments #23490

Draft

jiasli mentioned this pull request May 10, 2023

az ad sp create-for-rbac --display-name unrecognized argument #26388

Closed

evelyn-ys mentioned this pull request May 26, 2023

{Keyvault} Remove useless AAD endpoint and honor user input --subscription to support cross sub operations #26539

Merged

3 tasks

Nothing4You mentioned this pull request Jun 7, 2023

az ad sp delete claims to delete role assignments but it doesn't #26629

Closed

jiasli mentioned this pull request Aug 25, 2023

Migrate modules to Microsoft Graph #22174

Closed

jiasli mentioned this pull request Oct 26, 2023

az ad returns a Graph object without objectId property #22328

Closed

This was referenced Nov 7, 2024

{Graph} Remove the warning for Microsoft Graph migration #22612

Merged

[Profile] BREAKING CHANGE: az login: --password no longer accepts service principal certificate #30092

Merged

jiasli mentioned this pull request Apr 24, 2025

{Role} Clean up linter exclusion rules #31323

Merged

jiasli mentioned this pull request Jul 21, 2025

[Cloud] Update active_directory_graph_resource_id endpoint of AZURE_US_GOV_CLOUD #31849

Merged

jiasli mentioned this pull request Oct 23, 2025

az ad app credential reset should result same format than az ad app credential list #32307

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Role] `az ad/role`: Azure AD Graph API to Microsoft Graph API migration#22432

[Role] `az ad/role`: Azure AD Graph API to Microsoft Graph API migration#22432
jiasli merged 3 commits intoAzure:devfrom
jiasli:msgraph

jiasli commented May 13, 2022 •

edited

Loading

Uh oh!

azure-pipelines bot commented May 13, 2022

Uh oh!

yonzhan commented May 13, 2022 •

edited

Loading

Uh oh!

jiasli May 13, 2022

Uh oh!

jiasli commented May 16, 2022

Uh oh!

Uh oh!

Uh oh!

jsntcy May 16, 2022 •

edited

Loading

Uh oh!

jiasli May 16, 2022 •

edited

Loading

Uh oh!

lkurzyniec commented May 16, 2022

Uh oh!

jiasli commented May 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

jiasli commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Guide

Uh oh!

azure-pipelines bot commented May 13, 2022

Uh oh!

yonzhan commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jiasli May 13, 2022

Choose a reason for hiding this comment

Uh oh!

jiasli commented May 16, 2022

Uh oh!

Uh oh!

Uh oh!

jsntcy May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jiasli May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lkurzyniec commented May 16, 2022

Uh oh!

jiasli commented May 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jiasli commented May 13, 2022 •

edited

Loading

yonzhan commented May 13, 2022 •

edited

Loading

jsntcy May 16, 2022 •

edited

Loading

jiasli May 16, 2022 •

edited

Loading