[AD] az ad app/sp update: Support generic update --set on root level#22798
Merged
[AD] az ad app/sp update: Support generic update --set on root level#22798
az ad app/sp update: Support generic update --set on root level#22798Conversation
jiasli
commented
Jun 9, 2022
Member
Author
There was a problem hiding this comment.
AD Graph SDK uses verb "patch", instead of "update": azure.graphrbac.operations.applications_operations.ApplicationsOperations.patch. I guess it is used to differentiate with update_application of generic update.
We switch to use "update" to align with other update operations (such as azure.graphrbac.operations.users_operations.UsersOperations.update) and the API document https://docs.microsoft.com/en-us/graph/api/application-update.
Member
Author
|
The underlying functionality support of azure-cli/src/azure-cli-core/azure/cli/core/commands/arm.py Lines 502 to 503 in ce3a1f1 |
evelyn-ys
approved these changes
Jun 13, 2022
calvinhzy
approved these changes
Jun 13, 2022
az ad app/sp update: Support generic update --set on root levelaz ad app/sp update: Support generic update --set on root level
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az ad app updateaz ad sp updateDescription
Close #22758, #22777, #22635
az ad sp updatehas no native arguments, but only generic update arguments:https://docs.microsoft.com/en-us/cli/azure/microsoft-graph-migration#known-issues documented that generic update arguments are not supported by now. Therefore,
az ad sp updateis basically a no-op.This PR is an initial attempt to makes generic update work with the new model-less framework by supporting generic update
--setforaz ad app/sp updateon the root level: