Skip to content

{Pipeline} Bump version pipeline#22978

Merged
evelyn-ys merged 34 commits intoAzure:devfrom
evelyn-ys:bump_version_pipeline
Aug 18, 2022
Merged

{Pipeline} Bump version pipeline#22978
evelyn-ys merged 34 commits intoAzure:devfrom
evelyn-ys:bump_version_pipeline

Conversation

@evelyn-ys
Copy link
Member

Description

Add a new pipeline for bumping version. The related doc is also added.


This checklist is used to make sure that common guidelines for a pull request are followed.

@evelyn-ys evelyn-ys requested a review from kairu-ms as a code owner June 23, 2022 06:02
@evelyn-ys evelyn-ys marked this pull request as draft June 23, 2022 06:02
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 23, 2022

It is really good to provide bump version pipeline doc.

@evelyn-ys
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys evelyn-ys marked this pull request as ready for review August 15, 2022 08:12
Comment on lines +30 to +31
working_directory = "/home/vsts/work/1/s"
azdev_test_result_dir = "/home/vsts/.azdev/env_config/home/vsts/work/1/s/env"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get these directories by pipeline variables?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I just didn't find the env variables😂

Comment on lines +118 to +119
testResultsFiles: '/home/vsts/.azdev/env_config/home/vsts/work/1/s/env/test_results_*.xml'
testRunTitle: 'CLI Bump Version test results of instance $(Instance_idx)'
Copy link
Member

@wangzelin007 wangzelin007 Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very curious, where can we see the documentation for these two parameters?
I love this feature by the way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evelyn-ys evelyn-ys requested a review from jsntcy August 18, 2022 01:42
@evelyn-ys evelyn-ys merged commit 6d83c07 into Azure:dev Aug 18, 2022
testResultsFiles: '/home/vsts/.azdev/env_config/home/vsts/work/1/s/env/test_results_*.xml'
testRunTitle: 'CLI Bump Version test results of instance $(Instance_idx)'

- job: CreatePR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll be good to give an option to disable creating PR.

During live run, some tests may fail, so the PR created by azclibot cannot pass CI. The developer must manually fix those failed tests, but the developer may not have the permission to push to azclibot repo. In that case, the developer can add their changes onto azclibot's commits and push to their own forked repo, then creating a PR from their own forked repo (for example #28660). The PR created by azclibot becomes redundant and should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants