Conversation
ghost
requested review from
ghost
added
the
jiasli
commented
Sep 20, 2022
Comment on lines
421
to
429
Member
Author
There was a problem hiding this comment.
Ad-hoc API versions should be removed:
Member
Author
jiasli
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
necusjz and
zhoxing-ms
as code owners
3 tasks
yonzhan
modified the milestones:
Sep 2022 (2022-10-12) - For Ignite,
Oct 2022 (2022-11-01)
wangzelin007
approved these changes
Oct 26, 2022
necusjz
approved these changes
Oct 26, 2022
jsntcy
reviewed
Oct 26, 2022
| _LOGGER.info(f"{size_in_mb:.2f} MB, {count} files") | ||
|
|
||
|
|
||
| def _get_all_sdks_to_trim(): |
Member
There was a problem hiding this comment.
@jiasli, It seems this function is not used, do we need it?
Member
Author
There was a problem hiding this comment.
No. It's not. I keep it there so that we can trim all SDKs in the future.
zhoxing-ms
reviewed
Oct 26, 2022
zhoxing-ms
approved these changes
Oct 26, 2022
3 tasks
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce Azure CLI's package size per
This is because the bundled Python SDKs contain lots of code which is not used by Azure CLI (Azure/azure-sdk-for-python#11149).
This PR adds
trim-sdk.pyscript to trim Python SDKs byaiofolders