[Packaging] Drop Mariner 1.0 RPM package#24039
Merged
Conversation
jiasli
requested review from
calvinhzy,
kairu-ms and
wangzelin007
as code owners
ghost
requested a review
from 
ghost
added
the
jiasli
commented
Sep 28, 2022
| 2.0: | ||
| image: mcr.microsoft.com/cbl-mariner/base/core | ||
| tag: 2.0 | ||
| image: mcr.microsoft.com/cbl-mariner/base/core:2.0 |
Member
Author
There was a problem hiding this comment.
No need to have a separate variable tag. We can combine it with image.
jiasli
commented
Sep 28, 2022
Comment on lines
-615
to
-617
| env: | ||
| IMAGE: $(image) | ||
| TAG: $(tag) |
Member
Author
There was a problem hiding this comment.
System and user-defined variables also get injected as environment variables for your platform. When variables are turned into environment variables, variable names become uppercase, and periods turn into underscores. For example, the variable name
any.variablebecomes the variable name$ANY_VARIABLE.
So we don't need to explicitly declare env vars.
jiasli
changed the title
wangzelin007
approved these changes
Sep 28, 2022
Collaborator
|
Drop Mariner 1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #22605
Since CBL Mariner 2.0 is now GA, Mariner 1.0 will be fully deprecated roughly by the end of October.
We stop building RPM for Mariner 1.0 in 2.41.0 which is a breaking change window.