Skip to content

{AKS} az aks nodepool: Update nodepool command option names#24754

Merged
zhoxing-ms merged 5 commits into
Azure:devfrom
FumingZhang:fuming/align-nodepool-names-1128
Nov 29, 2022
Merged

{AKS} az aks nodepool: Update nodepool command option names#24754
zhoxing-ms merged 5 commits into
Azure:devfrom
FumingZhang:fuming/align-nodepool-names-1128

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Nov 28, 2022

Related command

Description

Testing Guide

History Notes

[AKS] az aks nodepool: Unify the option names used to specify the nodepool name and cluster name. For nodepool name, option names are --nodepool-name, --name and -n. For cluster name, option name is --cluster-name


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested review from wangzelin007 and zhoxing-ms November 28, 2022 06:15
@ghost ghost assigned zhoxing-ms Nov 28, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 28, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 28, 2022
@ghost ghost requested a review from yonzhan November 28, 2022 06:16
@ghost ghost added the AKS az aks/acs/openshift label Nov 28, 2022
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 28, 2022

AKS

Comment thread src/azure-cli/azure/cli/command_modules/acs/_params.py Outdated
@zhoxing-ms zhoxing-ms merged commit b28973d into Azure:dev Nov 29, 2022
@FumingZhang FumingZhang deleted the fuming/align-nodepool-names-1128 branch December 8, 2022 05:35
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
…24754)

* update nodepool command option names

* fix help

* add deprecation info for --agent-pool-name option in aks nodepool wait command

* hide by default

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants