Script that creates packaged releases package archive#2508
Script that creates packaged releases package archive#2508troydai merged 2 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
=======================================
Coverage 72.02% 72.02%
=======================================
Files 362 362
Lines 19766 19766
Branches 2913 2913
=======================================
Hits 14236 14236
+ Misses 4612 4608 -4
- Partials 918 922 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
The code looks good to me besides a few necessary changes. Besides those I left comments with the code, the others are:
- Run the code through PEP8 and pylint. We treat utility codes as seriously as product code.
- Add empty lines in the main function to improve readability.
packaged_releases/README.md
Outdated
There was a problem hiding this comment.
Make the command accept a response file instead of typing every module and their versions on the same line. It is too easy to make a mistake in this way.
There was a problem hiding this comment.
Added support for this.
There was a problem hiding this comment.
Make all these paths absolute paths by joining the segments with root path. It makes the paths deterministic, otherwise the relative path will be impacted by the working directory.
There was a problem hiding this comment.
By Design.
The paths here are supposed to be relative (see code above).
The first path is relative path from the repo root, the second is relative path to file to patch in the packaged release.
The REPO_ROOT_DIR is added to the first path, and the current working dir is added to the second path.
Saves a couple of hours during releasing for Docker/Debian
derekbekoe
force-pushed
the
automated-package-archive
branch
from
68f01cc to
188a78a
Compare
derekbekoe
left a comment
derekbekoe
left a comment
There was a problem hiding this comment.
@troydai comments addressed.
There was a problem hiding this comment.
By Design.
The paths here are supposed to be relative (see code above).
The first path is relative path from the repo root, the second is relative path to file to patch in the packaged release.
The REPO_ROOT_DIR is added to the first path, and the current working dir is added to the second path.
packaged_releases/README.md
Outdated
There was a problem hiding this comment.
Added support for this.
* Azure/master: (478 commits) vm live test: allow more valid power states on vmss test verifications (Azure#2564) rbac:catch more graph error (Azure#2567) appservice: support to create plan when create a webapp (Azure#2550) Update storage tests (Azure#2556) Change PEP8 check filter from whitelist to blacklist (Azure#2557) Add scenario tests documentation (Azure#2555) [ACS] Adding support for configuring a default ACS cluster (Azure#2554) [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553) Sql Import/Export CLI commands and test (Azure#2538) Fix format bug. (Azure#2549) [VM/VMSS] Improved disk caching support (Azure#2522) VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537) Script that creates packaged releases package archive (Azure#2508) Adding alias for defaults flag (Azure#2540) Add wait commands and --no-wait support (Azure#2524) choice list outside of named arguments (Azure#2521) Fixed test failure in test_sql_db_mgmt. (Azure#2530) core: support login using service principal with a cert (Azure#2457) Add note about being in preview (Azure#2512) vm:fix distro check mechanism used by disk encryption (Azure#2511) ...
5 participants
Saves a couple of hours during each release for Docker/Debian 😄