[AKS] graduate dual-stack to GA by tyler-lloyd · Pull Request #25256 · Azure/azure-cli

tyler-lloyd · 2023-01-27T21:09:24Z

Related command

az aks create and az aks update

Description

This PR introduces the properties from aks-extensions that support the dual-stack feature.
Dual-stack is moving to GA and part of the work includes baking it into the GA cli to remove
the dependency on aks-preview extension.

Testing Guide

Unit and live tests added, mostly copied from the aks-preview extension work.

Example create:

Creates a dual-stack cluster with user-specified IP ranges

az aks create -n myCluster -g myRG --ip-families ipv4,ipv6 --pod-cidrs 10.244.0.0/16,fd12:3456:f::/64 --service-cidrs 192.168.0.0/16,fd00:abcd:ff::/108

Example update:

Updates the current dual-stack cluster with 4 managed outbound IPv6 IPs

az aks update -n myCluster -g myRG --load-balanacer-managed-outbound-ipv6-count 4

History Notes

[AKS] az aks create: Add new parameter --pod-cidrs for setting the IP ranges used to allocate IPs to pods
[AKS] az aks create: Add new parameter --service-cidrs for setting the K8s service IPs
[AKS] az aks create: Add new parameter --ip-families for setting the IP types that should be used in a cluster (IPv4 or IPv6)
[AKS] az aks create: Add new parameter --load-balanacer-managed-outbound-ipv6-count for setting the number of IPv6 outbound IPs that AKS should managed for a cluster with IPv6 enabled
[AKS] az aks update: Support changing the load balancer managed outbound IPv6 count property

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2023-01-28T09:58:59Z

AKS

FumingZhang

For the lint failure, please update src/azure-cli/azure/cli/command_modules/acs/linter_exclusions.yml to bypass the check on load_balancer_managed_outbound_ipv6_count.

Please also update the PR title, as it will be included in the cli release note.

FumingZhang · 2023-01-31T02:34:10Z


    def test_configure_load_balancer_profile(self):
        managed_outbound_ip_count = 5
+        managed_outbound_ipv6_count = 4


This set of profile (hybrid_2020_09_01) is using a legacy API version 2020-11-01, does ipv6 related properties introduced at that time? If not, I think we'd better not touch these test files.

so 2020-11-01 does not have IPv6 changes but the test failed when I didn't add it because of the call to configure_load_balancer_profile ... should I just pass None instead?

Yes, should ensure that not setting this field (pass None) wouldn't break the function.

Signed-off-by: Tyler Lloyd <tyler.lloyd@microsoft.com>

FumingZhang

LGTM, queued a pipeline to test newly added test cases.

FumingZhang · 2023-02-03T04:39:45Z

                    else:
                        if (
                            self.get_load_balancer_managed_outbound_ip_count() or
+                            self.get_load_balancer_managed_outbound_ipv6_count() or


This validation is not included in aks-preview

I think that's an oversight then. we should raise an error if outbound type is UDR and there is IPv6 count defined similar to the _ip_count parameter. I added a unit test to cover this

FumingZhang · 2023-02-03T04:44:50Z


    def test_configure_load_balancer_profile(self):
        managed_outbound_ip_count = 5
+        managed_outbound_ipv6_count = 4


Yes, should ensure that not setting this field (pass None) wouldn't break the function.

FumingZhang

LGTM

zhoxing-ms · 2023-02-06T03:00:33Z

[AKS] az aks create: Add properties that support dual-stack, pod-cidrs, service-cidrs, ip-families, and load-balanacer-managed-outbound-ipv6-count

Please describe the feature of the new parameters more detail in the history notes, it is better to have a separate record for each parameter~

tyler-lloyd · 2023-02-24T19:01:34Z

[AKS] az aks create: Add properties that support dual-stack, pod-cidrs, service-cidrs, ip-families, and load-balanacer-managed-outbound-ipv6-count

Please describe the feature of the new parameters more detail in the history notes, it is better to have a separate record for each parameter~

@zhoxing-ms updated the PR description with more details for each parameter. I don't see a HISTORY.rst for the GA cli so let me know if the details should go anywhere else.

zhoxing-ms · 2023-02-27T08:25:26Z

[AKS] az aks create: Add properties that support dual-stack, pod-cidrs, service-cidrs, ip-families, and load-balanacer-managed-outbound-ipv6-count

pod-cidrs - is a comma separated list of CIDRs that are used for allocating IPs to pods

service-cidrs - is a comma separated list of CIDRs that are used for K8s service IPs

ip-families - is a comma separated list of the IP types that should be used in a cluster (IPv4 or IPv6)

load-balanacer-managed-outbound-ipv6-count - is the number of IPv6 outbound IPs that AKS should managed for a cluster with IPv6 enabled

Since the current history notes cannot support the display of the list format, please write a separate record for each new parameter

tyler-lloyd · 2023-02-28T11:34:27Z

Since the current history notes cannot support the display of the list format, please write a separate record for each new parameter

@zhoxing-ms ~~sorry what do you mean by separate record?~~ I think I got it. Updated the description to have each parameter as a single line for the history.

zhoxing-ms · 2023-03-01T02:10:13Z

@tyler-lloyd I have refined the description of history notes, could you help to see if it meets your expectations?

tyler-lloyd · 2023-03-01T02:14:50Z

made one small update to the --pod-cidrs description but lgtm

zhoxing-ms · 2023-03-01T03:43:43Z

+      - AZURECLI/2.44.1 azsdk-python-azure-mgmt-containerservice/21.1.0 Python/3.10.6
+        (Linux-5.15.0-1031-azure-x86_64-with-glibc2.35)
+    method: PUT
+    uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2022-11-01


The api-version here should be 2023-01-01 instead of 2022-11-01 after bumping the api-version of Microsoft.ContainerService PR link: #25524

@tyler-lloyd @FumingZhang Please help pull the latest code from remote dev branch, then please re-recording these failed tests test_aks_create_and_update_ipv6_count and test_aks_create_dualstack_with_default_network

pie-r · 2024-08-16T13:07:14Z

We need the flag --pod-cidrs also for the az aks update. Otherwise the update in place is not possible.

pie-r · 2024-08-16T13:33:58Z

@yonzhan
@bragi92

tyler-lloyd added 3 commits January 27, 2023 14:57

feat: add IPv6 support for AKS

32ea278

feat: add ipv6 count to update lb

3fc1c7e

test: add unit and live tests for dual-stack

e5c7d21

tyler-lloyd requested review from andyliuliming, jsntcy, yanzhudd and zhoxing-ms as code owners January 27, 2023 21:09

ghost assigned zhoxing-ms Jan 27, 2023

ghost added this to the Jan 2023 (2023-02-07) milestone Jan 27, 2023

ghost added the Auto-Assign Auto assign by bot label Jan 27, 2023

ghost requested a review from yonzhan January 27, 2023 21:09

ghost added the AKS az aks/acs/openshift label Jan 27, 2023

tyler-lloyd added 2 commits January 27, 2023 21:26

docs: add help text

614d088

chore: address linter errors

1515db1

yonzhan modified the milestones: Jan 2023 (2023-02-07), Feb 2023 (2023-03-07) Jan 28, 2023

test(fix): update 2020-09-01 lb test with ipv6

e0dbfa0

FumingZhang reviewed Jan 31, 2023

View reviewed changes

tyler-lloyd added 2 commits February 2, 2023 23:25

chore: add ipv6_count to linter exclusion

e9dbd1b

test: pass None for IPv6 count for older API test

03a93b3

Signed-off-by: Tyler Lloyd <tyler.lloyd@microsoft.com>

FumingZhang reviewed Feb 3, 2023

View reviewed changes

test: add mutually exclusive error case for udr + ipv6 count

b5ed2cf

FumingZhang approved these changes Feb 6, 2023

View reviewed changes

zhoxing-ms approved these changes Mar 1, 2023

View reviewed changes

zhoxing-ms merged commit 43ceaa9 into Azure:dev Mar 1, 2023

zhoxing-ms reviewed Mar 1, 2023

View reviewed changes

FumingZhang mentioned this pull request Mar 7, 2023

{AKS} Fix UT for setting up network profile Azure/azure-cli-extensions#5951

Merged

3 tasks

avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023

[AKS] graduate dual-stack to GA (Azure#25256)

307ce51

Conversation

tyler-lloyd commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Jan 28, 2023

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

tyler-lloyd Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

FumingZhang Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

FumingZhang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FumingZhang Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

tyler-lloyd Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

FumingZhang Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms commented Feb 6, 2023

Uh oh!

tyler-lloyd commented Feb 24, 2023

Uh oh!

zhoxing-ms commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tyler-lloyd commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhoxing-ms commented Mar 1, 2023

Uh oh!

tyler-lloyd commented Mar 1, 2023

Uh oh!

zhoxing-ms Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

pie-r commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pie-r commented Aug 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tyler-lloyd commented Jan 27, 2023 •

edited

Loading

FumingZhang left a comment •

edited

Loading

zhoxing-ms commented Feb 27, 2023 •

edited

Loading

tyler-lloyd commented Feb 28, 2023 •

edited

Loading

zhoxing-ms Mar 1, 2023 •

edited

Loading

pie-r commented Aug 16, 2024 •

edited

Loading