[Storage] `az storage blob copy start`: Fix auth issue when providing source uri containing sas token by evelyn-ys · Pull Request #25880 · Azure/azure-cli

evelyn-ys · 2023-03-20T04:47:41Z

Related command

az storage blob copy start

Description

To fix the issue when copying from source uri containing sas token with specific tier:

> az storage blob copy start -b test.copy.txt -c tmpcontainer --account-name yssa --source-uri """https://yssa.blob.core.windows.net/tmpcontainer/test.txt?sp=r&st=2023-03-20T04:35:32Z&se=2023-03-20T12:35:32Z&spr=https&sv=2021-12-02&sr=b&sig=y5g%2BkqmQgOiMBS4pCzjPI8Ihd6EG2HcydEhjq0DZiI8%3D"""
 --tier Cool

ERROR: Authentication information is not given in the correct format. Check the value of Authorization header.
ErrorCode:None

This error is throw from line 1047

azure-cli/src/azure-cli/azure/cli/command_modules/storage/operations/blob.py

Lines 1046 to 1055 in e072af7

    
           if kwargs.get('tier') is not None: 
        
               src_properties = src_client.get_blob_properties() 
        
               BlobType = cmd.get_models('_models#BlobType') 
        
               tier = kwargs.pop('tier') 
        
               if src_properties.blob_type == BlobType.BlockBlob: 
        
                   kwargs["standard_blob_tier"] = getattr(StandardBlobTier, tier) 
        
               elif src_properties.blob_type == BlobType.PageBlob: 
        
                   PremiumPageBlobTier = cmd.get_models('_models#PremiumPageBlobTier') 
        
                   kwargs["premium_page_blob_tier"] = getattr(PremiumPageBlobTier, tier) 
        
           return client.start_copy_from_url(source_url=source_url, metadata=metadata, incremental_copy=False, **kwargs)

The src_client doesn't contain proper credential. But we actually don't need to call src_client.get_blob_properties here.
The tier can be either StandardBlobTier type or PremiumPageBlobTier, we can simply leverage AttributeError to identify the correct type

Testing Guide

az storage blob copy start -b $blobName -c $containerName --account-name $accountName --source-uri $sourceWithSAS --tier Archieve/Cool/Hot

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

…i containing sas token

azure-client-tools-bot-prd · 2023-03-20T04:47:44Z

️✔️acr

️✔️acs

️✔️advisor

️✔️ams

️✔️apim

️✔️appconfig

️✔️appservice

️✔️aro

️✔️backup

️✔️batch

️✔️batchai

️✔️billing

️✔️botservice

️✔️cdn

️✔️cloud

️✔️cognitiveservices

️✔️config

️✔️configure

️✔️consumption

️✔️container

️✔️core

️✔️cosmosdb

️✔️databoxedge

️✔️dla

️✔️dls

️✔️dms

️✔️eventgrid

️✔️eventhubs

️✔️feedback

️✔️find

️✔️hdinsight

️✔️identity

️✔️iot

️✔️keyvault

️✔️kusto

️✔️lab

️✔️managedservices

️✔️maps

️✔️marketplaceordering

️✔️monitor

️✔️netappfiles

️✔️network

️✔️policyinsights

️✔️privatedns

️✔️profile

️✔️rdbms

️✔️redis

️✔️relay

️✔️resource

️✔️role

️✔️search

️✔️security

️✔️servicebus

️✔️serviceconnector

️✔️servicefabric

️✔️signalr

️✔️sql

️✔️sqlvm

️✔️storage

️✔️synapse

️✔️telemetry

️✔️util

️✔️vm

yonzhan · 2023-03-20T05:09:57Z

storage

… source uri containing sas token (Azure#25880)

az storage blob copy start: Fix auth issue when providing source ur…

bf99468

…i containing sas token

evelyn-ys requested review from calvinhzy, jsntcy and zhoxing-ms as code owners March 20, 2023 04:47

ghost added the Auto-Assign Auto assign by bot label Mar 20, 2023

ghost requested a review from yonzhan March 20, 2023 04:47

ghost assigned evelyn-ys Mar 20, 2023

ghost added this to the March 2023 (2023-04-04) milestone Mar 20, 2023

ghost added the Storage az storage label Mar 20, 2023

evelyn-ys requested a review from MoChilia March 20, 2023 04:48

evelyn-ys mentioned this pull request Mar 20, 2023

[storage-blob-preview] az storage blob copy start: Fix auth issue Azure/azure-cli-extensions#6039

Merged

3 tasks

calvinhzy approved these changes Mar 20, 2023

View reviewed changes

MoChilia approved these changes Mar 20, 2023

View reviewed changes

evelyn-ys merged commit 946e67e into Azure:dev Mar 20, 2023

avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023

[Storage] az storage blob copy start: Fix auth issue when providing…

f8eba9e

… source uri containing sas token (Azure#25880)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] `az storage blob copy start`: Fix auth issue when providing source uri containing sas token#25880

[Storage] `az storage blob copy start`: Fix auth issue when providing source uri containing sas token#25880
evelyn-ys merged 1 commit into
Azure:devfrom
evelyn-ys:storage_blob_copy_failure_with_tier

evelyn-ys commented Mar 20, 2023

Uh oh!

azure-client-tools-bot-prd Bot commented Mar 20, 2023 •

edited

Loading

Uh oh!

yonzhan commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if kwargs.get('tier') is not None:
	src_properties = src_client.get_blob_properties()
	BlobType = cmd.get_models('_models#BlobType')
	tier = kwargs.pop('tier')
	if src_properties.blob_type == BlobType.BlockBlob:
	kwargs["standard_blob_tier"] = getattr(StandardBlobTier, tier)
	elif src_properties.blob_type == BlobType.PageBlob:
	PremiumPageBlobTier = cmd.get_models('_models#PremiumPageBlobTier')
	kwargs["premium_page_blob_tier"] = getattr(PremiumPageBlobTier, tier)
	return client.start_copy_from_url(source_url=source_url, metadata=metadata, incremental_copy=False, **kwargs)

Conversation

evelyn-ys commented Mar 20, 2023

Uh oh!

azure-client-tools-bot-prd Bot commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azure-client-tools-bot-prd Bot commented Mar 20, 2023 •

edited

Loading