Skip to content

{Telemetry} Reduce default pushing interval for local telemetry cache to 1h #26509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 1 commit into from
May 30, 2023
Merged

{Telemetry} Reduce default pushing interval for local telemetry cache to 1h #26509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/azure-cli-telemetry/azure/cli/telemetry/components/records_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ def snapshot_and_read(self):

def _get_push_interval_config(self):
config = CLIConfig(config_dir=self._config_dir)
threshold = config.getint('telemetry', 'push_interval_in_hours', fallback=6)
# the threshold for push telemetry can't be less than 1 hour, default value is 6 hours
return threshold if threshold >= 1 else 6
threshold = config.getint('telemetry', 'push_interval_in_hours', fallback=1)
# the threshold for push telemetry can't be less than 1 hour, default value is 1 hour
return threshold if threshold >= 1 else 1

def _read_file(self, path):
""" Read content of a telemetry cache file and parse them into records. """
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli-telemetry/azure/cli/telemetry/tests/test_records_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ def test_create_records_collection(self):
self.assertEqual(1758, len([r for r in collection]))

def test_create_records_collection_with_last_send(self):
last_send = datetime.datetime.now() - datetime.timedelta(hours=2)
last_send = datetime.datetime.now() - datetime.timedelta(minutes=20)
collection = RecordsCollection(last_send, self.work_dir)
collection.snapshot_and_read()

# the threshold for pushing 'cache' file is 6, so 'cache' file should not be moved
# the threshold for pushing 'cache' file is 1 hour, so 'cache' file should not be moved
self.assert_cache_files_count(1)
# no new records since last_send
self.assertEqual(0, len([r for r in collection]))
Expand Down