Conversation
mwesigwaguma
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| is_break | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| sf managed-cluster network-security-rule | sub group sf managed-cluster network-security-rule added |
ghost
requested a review
from 
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ghost
added
the
necusjz
added
Service Fabric
Member
|
/azp run Azure.azure-cli Breaking Change Test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mwesigwaguma
changed the title
LukeSlev
reviewed
Jun 15, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py
Show resolved
Hide resolved
LukeSlev
reviewed
Jun 15, 2023
mwesigwaguma
changed the title
LukeSlev
reviewed
Jun 23, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Jun 26, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
Contributor
|
Please refer to the guideline to write the description of those PR changes in the |
Contributor
Author
I added what I thought were the main changes |
LukeSlev
reviewed
Jun 26, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
LukeSlev
approved these changes
Jun 26, 2023
zhoxing-ms
reviewed
Jun 27, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Jun 27, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
Jun 27, 2023
src/azure-cli/azure/cli/command_modules/servicefabric/_params.py
Outdated
Show resolved
Hide resolved
Contributor
|
@mwesigwaguma Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 08-01) |
Contributor
Author
resolved all comments and tests are passing. Should be all set |
yanzhudd
changed the title
az sf managed-cluster network-security-rule add: Add command to add network security rule to managed cluster
yanzhudd
approved these changes
Jun 28, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…dd command to add network security rule to managed cluster (Azure#26510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Command to add network security rule to managed cluster
Testing Guide
see src\azure-cli\azure\cli\command_modules\help.py for examples and descriptions
History Notes
[Service Fabric]
az sf managed-cluster network-security-rule add: Add network security rule to managed clusterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.