[AKS] az acs maintenanceconfiguration: Add Operations for Maintenance Configuration#26758
Merged
zhoxing-ms merged 39 commits intoAzure:devfrom Jul 26, 2023
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @anushkasingh16, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks maintenanceconfiguration | sub group aks maintenanceconfiguration added |
Collaborator
|
draft |
anushkasingh16
changed the title
anushkasingh16
changed the title
anushkasingh16
changed the title
az acs maintenanceconfiguration: Add Operations for Maintenance Configuration
added 11 commits
June 26, 2023 13:50
This reverts commit 50bbbcd.
anushkasingh16
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
FumingZhang
reviewed
Jun 28, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please resolve the above comments (rebase/merge dev, remove register_resource_type, re-queue pipeline to get new recordings).
May pick the commit cfffc88 from branch fuming/tmp.
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_maintenanceconfiguration.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
This reverts commit 7a79812.
zhoxing-ms
reviewed
Jul 25, 2023
zhoxing-ms
reviewed
Jul 25, 2023
zhoxing-ms
reviewed
Jul 25, 2023
zhoxing-ms
reviewed
Jul 25, 2023
zhoxing-ms
reviewed
Jul 25, 2023
| g.custom_show_command('show', 'aks_maintenanceconfiguration_show') | ||
| g.custom_command('add', 'aks_maintenanceconfiguration_add') | ||
| g.custom_command('update', 'aks_maintenanceconfiguration_update') | ||
| g.custom_command('delete', 'aks_maintenanceconfiguration_delete') |
Contributor
There was a problem hiding this comment.
Do we need to consider adding confirmation=true for the delete command?
Contributor
There was a problem hiding this comment.
Also, I would like to confirm if there is the same command aks maintenanceconfiguration delete in the CLI extension?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
OK, so I think we need to keep consistent with CLI extension, otherwise, this may confuse or even block the customer's automated scripts
zhoxing-ms
reviewed
Jul 25, 2023
Contributor
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 09-05) |
Member
|
Queued live test pipeline, test passed. |
zhoxing-ms
approved these changes
Jul 26, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…ce Configuration (Azure#26758)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks maintenanceconfigurationDescription
In the
az aksgroup, adding in themaintenanceconfigurationsubgroup:The above commands will be used for Planned Maintenance of AKS clusters.
Testing Guide
History Notes
[AKS]
az aks maintenanceconfiguration list: Add new command to list all maintenance windows in a cluster[AKS]
az aks maintenanceconfiguration show: Add new command to display a specific maintenance windows of a cluster[AKS]
az aks maintenanceconfiguration add: Add new command to add a new maintenance window configuration for a cluster[AKS]
az aks maintenanceconfiguration update: Add new command to update an existing maintenance window configuration of a cluster[AKS]
az aks maintenanceconfiguration delete: Add new command to delete an existing maintenance window configuration of a clusterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.