Skip to content

Comments

[Storage] az storage account create/update, az storage account network-rule add/remove: Support IPv6 preview#26826

Merged
calvinhzy merged 18 commits intoAzure:devfrom
calvinhzy:storage-ipv6-private-preview
Jan 16, 2026
Merged

[Storage] az storage account create/update, az storage account network-rule add/remove: Support IPv6 preview#26826
calvinhzy merged 18 commits intoAzure:devfrom
calvinhzy:storage-ipv6-private-preview

Conversation

@calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Jul 6, 2023

Related command

Description

Add ipv6 preview support to storage account.

Testing Guide

History Notes

[Storage] az storage account create/update: Add --publish-ipv6-endpoint
[Storage] az storage account network-rule add/remove: Add --ipv6-address


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 6, 2023

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️postgresql
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 6, 2023

⚠️AzureCLI-BreakingChangeTest
⚠️storage
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd storage account create cmd storage account create added parameter publish_ipv6_endpoint
⚠️ 1006 - ParaAdd storage account network-rule add cmd storage account network-rule add added parameter ipv6_address
⚠️ 1006 - ParaAdd storage account network-rule remove cmd storage account network-rule remove added parameter ipv6_address
⚠️ 1006 - ParaAdd storage account update cmd storage account update added parameter publish_ipv6_endpoint

@ghost ghost added the Auto-Assign Auto assign by bot label Jul 6, 2023
@ghost ghost requested a review from evelyn-ys July 6, 2023 02:26
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 6, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yonzhan July 6, 2023 02:27
@ghost ghost assigned evelyn-ys Jul 6, 2023
@ghost ghost added the Storage az storage label Jul 6, 2023
calvinhzy added 5 commits July 6, 2023 10:45
…li\command_modules\storage\tests\latest\test_storage_adls_gen2_scenarios.py::StorageADLSGen2Tests::test_storage_fs_directory_generate_sas_as_user - a...

FAILED azure-cli\src\azure-cli\azure\cli\command_modules\storage\tests\latest\test_storage_account_scenarios.py::StorageAccountHNSMigrationScenarioTest::test_storage_account_start_hns_migration
FAILED azure-cli\src\azure-cli\azure\cli\command_modules\storage\tests\latest\test_storage_account_scenarios.py::StorageAccountLocalContextScenarioTest::test_storage_account_local_context
FAILED azure-cli\src\azure-cli\azure\cli\command_modules\storage\tests\latest\test_storage_account_scenarios.py::StorageAccountORScenarioTest::test_storage_account_allow_cross_tenant_replication
FAILED azure-cli\src\azure-cli\azure\cli\command_modules\storage\tests\latest\test_storage_cors_scenarios.py::StorageCorsTests::test_storage_cors_scenario - AssertionError: 6 != 7
FAILED azure-cli\src\azure-cli\azure\cli\command_modules\storage\tests\latest\test_storage_file_scenarios.py::StorageFileShareScenarios::test_storage_file_main_oauth_scenario - azure.core...
… --publish-ipv4-endpoint --publish-ipv6-endpoint
@calvinhzy calvinhzy changed the title Storage ipv6 private preview [Storage] az storage account create/update: IPv6 private preview Aug 15, 2023
@calvinhzy calvinhzy changed the title [Storage] az storage account create/update: IPv6 private preview [Storage] az storage account create/update, az storage account network-rule add/remove: IPv6 private preview Aug 15, 2023
…ove publish IPv4 (IPv4 always publish) setting and DualStack setting.
…-preview

# Conflicts:
#	src/azure-cli/azure/cli/command_modules/storage/_params.py
#	src/azure-cli/azure/cli/command_modules/storage/operations/account.py
@calvinhzy calvinhzy changed the title [Storage] az storage account create/update, az storage account network-rule add/remove: IPv6 private preview [Storage] az storage account create/update, az storage account network-rule add/remove: IPv6 preview Jan 12, 2026
@calvinhzy calvinhzy changed the title [Storage] az storage account create/update, az storage account network-rule add/remove: IPv6 preview [Storage] az storage account create/update, az storage account network-rule add/remove: Support IPv6 preview Jan 12, 2026
@calvinhzy calvinhzy marked this pull request as ready for review January 14, 2026 07:46
Copilot AI review requested due to automatic review settings January 14, 2026 07:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds IPv6 preview support to Azure Storage account commands, enabling users to publish IPv6 endpoints and manage IPv6 network rules.

Changes:

  • Added --publish-ipv6-endpoint flag to storage account create and storage account update commands
  • Added --ipv6-address parameter to storage account network-rule add and storage account network-rule remove commands
  • Refactored IP address overlap validation logic to support both IPv4 and IPv6

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test_storage_account_scenarios.py Added comprehensive test for IPv6 endpoint and network rule functionality
test_storage_account_ipv6.yaml Test recording file for the new IPv6 test scenarios
account.py Implemented IPv6 endpoint preference and IPv6 network rule add/remove operations
_validators.py Refactored IP overlap validation and added IPv6-specific validator
_params.py Added parameter definitions for IPv6 endpoint and address options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@calvinhzy calvinhzy requested a review from evelyn-ys January 15, 2026 10:48
@calvinhzy calvinhzy merged commit f347b33 into Azure:dev Jan 16, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Storage az storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants