[ARM] Fix #26112: az deployment group create: Fix the warning log mode is not a known attribute of class TemplateLink#26984
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Jul 31, 2023
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @detienne20, |
ghost
added
the
customer-reported
|
Thank you for your contribution detienne20! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
Contributor
|
Thank you for your contribution detienne20! We will review the pull request and get back to you soon. |
Collaborator
|
ARM |
microsoft-github-policy-service
bot
added
the
ARM
zhoxing-ms
changed the title
az deployment group create: Fix warning mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored for parameter --template-specs
added 2 commits
July 27, 2023 23:03
zhoxing-ms
changed the title
az deployment group create: Fix warning mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored for parameter --template-specs az deployment group create: Fix the warning log mode is not a known attribute of class TemplateLink
zhoxing-ms
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az deployment group create --resource-group {} --name {} --template-spec {} --parameters {}Description
This PR fixes issue #26798 and #26112. Issue was introduced by #14448. The mode property has never been a part of the Template Link class we see in the original SDK that introduced it. https://github.com/Azure/azure-sdk-for-python/blob/27e4203818e227ba2604ff52dcf55ce2293c4c37/sdk/resources/azure-mgmt-resource/azure/mgmt/resource/resources/v2020_06_01/models/_models_py3.py#L2540-L2543
Testing Guide
az deployment group create --resource-group {} --name {} --template-spec {} --parameters {}should NOT issue the warning "mode is not a known attribute of class <class 'azure.mgmt.resource.resources.v2022_09_01.models._models_py3.TemplateLink'> and will be ignored"History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.