{Telemetry} Add telemetry log for local debugging#27004
Closed
{Telemetry} Add telemetry log for local debugging#27004
Conversation
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Telemetry |
jiasli
reviewed
Jul 26, 2023
| if not client: | ||
| continue | ||
|
|
||
| self._logger.info('Add %d record(s) to client %s for uploading: %s', len(records), instrumentation_key, records) |
Member
There was a problem hiding this comment.
Will $HOMEDIR/.azure/logs/telemetry.log be rotated? We certainly don't want it to grow indefinitely as time passes.
jiasli
reviewed
Jul 26, 2023
| if not client: | ||
| continue | ||
|
|
||
| self._logger.info('Add %d record(s) to client %s for uploading: %s', len(records), instrumentation_key, records) |
Member
There was a problem hiding this comment.
Under what circumstances will records be greater than 1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have dropped telemetry local cache strategy in #26854. So there won't be
cachefile under$HOMEDIR/.azure/telemetryfolder anymore. This brings some trouble for CLI developers when they add/modify some telemetry properties.So this PR adds telemetry log with full property values which was used to be stored in
cachefile. Developers can now check$HOMEDIR/.azure/logs/telemetry.logfor local debuggingTesting Guide
Run any CLI command then check
$HOMEDIR/.azure/logs/telemetry.log, there should be log like this:This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.