{Packaging} Vendor azure-mgmt-datalake-analytics#27163
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
Collaborator
|
Packaging |
Member
|
My script from #27047 (comment) didn't find this |
Member
|
|
bebound
requested review from
calvinhzy,
evelyn-ys,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
bebound
changed the title
azure-mgmt-datalake-analytics
bebound
force-pushed
the
bump-analytics
branch
from
f3779e2 to
87e1db7
Compare
evelyn-ys
previously approved these changes
Aug 15, 2023
bebound
force-pushed
the
bump-analytics
branch
from
e4c12fe to
324ed1f
Compare
bebound
force-pushed
the
bump-analytics
branch
from
324ed1f to
15464a3
Compare
jsntcy
previously approved these changes
Aug 15, 2023
jiasli
reviewed
Aug 16, 2023
Contributor
Author
There was a problem hiding this comment.
From azure/cli/command_modules/keyvault/vendored_sdks/__init__.py
jiasli
reviewed
Aug 16, 2023
| def cf_dla_account(cli_ctx, _): | ||
| from azure.cli.core.commands.client_factory import get_mgmt_service_client | ||
| from azure.mgmt.datalake.analytics.account import DataLakeAnalyticsAccountManagementClient | ||
| from azure.cli.command_modules.dla.vendored_sdks.azure_mgmt_datalake_analytics.account import DataLakeAnalyticsAccountManagementClient |
Member
There was a problem hiding this comment.
It may be better to use relative import since azure.cli.command_modules.dla.vendored_sdks is in the same package azure.cli.command_modules.dla as azure.cli.command_modules.dla._client_factory.
This may also save us from adding # pylint: disable=line-too-long.
Suggested change
| from azure.cli.command_modules.dla.vendored_sdks.azure_mgmt_datalake_analytics.account import DataLakeAnalyticsAccountManagementClient | |
| from .vendored_sdks.azure_mgmt_datalake_analytics.account import DataLakeAnalyticsAccountManagementClient |
Contributor
Author
There was a problem hiding this comment.
I've changed to relative import.
Weird, we hardly use relative import in azure-cli.
jiasli
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
0.2.1 is not compatible with Homebrew, see #27047.
The Track 2 SDK lacks
azure.mgmt.datalake.analytics.jobandazure.mgmt.datalake.analytics.catalog, vender it instead.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.