{Core} Make the recommendation for SSLError more accurate#27857
Draft
{Core} Make the recommendation for SSLError more accurate#27857
SSLError more accurate#27857Conversation
🔄AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
added
Auto-Assign
Collaborator
|
Core |
bebound
reviewed
Nov 20, 2023
| 'Please add this certificate to the trusted CA bundle. More info: https://docs.microsoft.com/cli/azure/use-cli-effectively#work-behind-a-proxy.') | ||
| SSLERROR_TEMPLATE = ('An SSL error occurred. This typically happens when using Azure CLI behind a proxy or firewall. ' | ||
| 'For more information, see: ' | ||
| 'https://learn.microsoft.com/cli/azure/use-cli-effectively#work-behind-a-proxy') |
Contributor
There was a problem hiding this comment.
Can we distinguish the firewall error and certificate error further based on error message?
The certificate error is Caused by SSLError(SSLCertVerificationError.
The firewall error is Caused by SSLError(SSLEOFError. In this case, we can suggest users adding endpoints to allowlist: https://learn.microsoft.com/en-us/cli/azure/azure-cli-endpoints?tabs=azure-cloud
Member
Author
There was a problem hiding this comment.
To some extent, firewall is a special type of proxy. I think we can elaborate it in the doc, but keep the error message simple.
Also, I think SSLEOFError is only one type of SSLError caused by firewall. There may be other firewalls out there causing other SSLErrors. Capturing the base SSLError covers more scenarios.
yonzhan
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#11093 added recommendation for
requests.exceptions.SSLError. However, not allSSLErrors are caused by untrusted self-signed certificate. For example, when a firewall blocks https://management.azure.com/, anrequests.exceptions.SSLErrorwill be raised:This PR refines the recommendation message to make it more accurate.
Testing Guide
TBD