{AppService} az functionapp: Show error message for language end of life support#28154
Merged
zhoxing-ms merged 4 commits intodevfrom Jan 29, 2024
Merged
{AppService} az functionapp: Show error message for language end of life support#28154zhoxing-ms merged 4 commits intodevfrom
az functionapp: Show error message for language end of life support#28154zhoxing-ms merged 4 commits intodevfrom
Conversation
kamperiadis
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AppService |
arroyc
approved these changes
Jan 10, 2024
zhoxing-ms
approved these changes
Jan 29, 2024
jiasli
reviewed
Nov 8, 2024
Comment on lines
+3632
to
+3634
| if eol < today: | ||
| raise ValidationError('{} has reached EOL on {} and is no longer supported. {}' | ||
| .format(runtime, eol.date(), runtime_deprecation_link)) |
Member
There was a problem hiding this comment.
This check sets a time bomb and blows up the CI at exactly today - 2024-11-08 (#30289 (comment)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp createDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.