{testsdk} Stop patching AZURE_CONFIG_DIR immediately after calling AzCli.__init__#28857
Draft
{testsdk} Stop patching AZURE_CONFIG_DIR immediately after calling AzCli.__init__#28857
AZURE_CONFIG_DIR immediately after calling AzCli.__init__#28857Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
testsdk |
Member
Author
|
A workaround I am currently using is to run these tests with different module="test_containerapp_manualjob_withsecret_crudoperations_e2e test_hdinsight_application"
for m in $module; do
echo Running azdev for $m
azdev test --series --no-exitfirst $m
azdev test --series --no-exitfirst --live --lf $m
done |
Contributor
|
Hmm, I believe the live mode works without env |
jiasli
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
June 2024 (2024-07-02)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
patch.dictpollution:azure.cli.testsdk.base.ScenarioTest.__init__of each test class is run at pytest's collecting staging, in the same process, buttearDownis executed after test methods have been finished. As no test method has been run yet,patch.dict(os.environ, {'AZURE_CONFIG_DIR': config_dir})is not stopped, thus polluting other test classes'__init__methods at collecting stage and other test methods at running stage.Consider
Even though #28853 bypasses the command index initialization and makes playback test work, during live test, after
test_containerapp_manualjob_withsecret_crudoperations_e2efinishes, the random config dir is deleted. Because of thepatch.dictpollution,test_hdinsight_applicationuses the same random config dir, but can't findmsal_token_cache.jsonand fails:This PR doesn't make things worse than #28673 as currently the
AZURE_CONFIG_DIRenv var is already polluted when running test methods. For example:When running
test_method_A,AZURE_CONFIG_DIRisrandom_config_dir_B.Testing Guide